fix(recommendations-plugin): avoid duplicated plug-ins

plugins/recommendations-plugin/src/strategy/featured-plugin-strategy.ts

@@ -38,11 +38,13 @@ export class FeaturedPluginStrategy {
     this.outputChannel.appendLine(`getFeaturedPlugins.foundLanguageIds=${foundLanguageIds}`);
 
     // Now compare with what we have as plugin-registry recommendations
-    const value = foundLanguageIds
+    const plugins = foundLanguageIds
       .map(languageId => this.matchingPlugins(languageId, featurePluginStrategyRequest.featuredList))
       .reduce((acc, e) => acc.concat(e), []);
-    this.outputChannel.appendLine(`getFeaturedPlugins.value=${value}`);
-    return value;
+
+    const uniquePlugins = [...new Set(plugins)];
+    this.outputChannel.appendLine(`getFeaturedPlugins.value=${uniquePlugins}`);
+    return uniquePlugins;
   }
 
   protected matchingPlugins(languageId: string, featuredList: FeaturedPlugin[]): string[] {

plugins/recommendations-plugin/tests/strategy/featured-plugin-strategy.spec.ts

@@ -128,4 +128,46 @@ describe('Test FeaturedPluginStrategy', () => {
     expect(featuredPlugins).toBeDefined();
     expect(featuredPlugins.length).toBe(0);
   });
+
+  test('basic xml with duplicated plug-ins', async () => {
+    const featuredPluginStrategy = container.get(FeaturedPluginStrategy);
+
+    // xml language is associated to multiple file extensions
+    languagesByFileExtensions.set('.xml', ['xml']);
+    languagesByFileExtensions.set('.jmx', ['xml']);
+    languagesByFileExtensions.set('.svg', ['xml']);
+    vscodeExtensionByLanguageId.set('xml', ['redhat/xml']);
+
+    const featured: FeaturedPlugin = {
+      id: 'redhat/xml',
+      onLanguages: ['xml'],
+      workspaceContains: [],
+      contributes: {
+        languages: [
+          {
+            id: 'xml',
+            aliases: [],
+            extensions: ['.xml'],
+            filenames: [],
+          },
+        ],
+      },
+    };
+    const featuredList = [featured];
+    const extensionsInCheWorkspace = ['.xml', '.unknown', '.jmx', '.svg'];
+    const devfileHasPlugins = true;
+
+    const request: FeaturedPluginStrategyRequest = {
+      featuredList,
+      vsCodeExtensionsInstalledLanguages,
+      devfileHasPlugins,
+      extensionsInCheWorkspace,
+    };
+
+    const featuredPlugins = await featuredPluginStrategy.getFeaturedPlugins(request);
+    expect(featuredPlugins).toBeDefined();
+    // only one instance of the plug-in even if there are multiple matches
+    expect(featuredPlugins.length).toBe(1);
+    expect(featuredPlugins[0]).toBe('redhat/xml');
+  });
 });