Skip to content

Conversation

@smoors
Copy link
Contributor

@smoors smoors commented Mar 3, 2024

motivation

  • leverage EB to install data in a standardized way with proper versioning and checksumming
  • support adding datasets as dependency for software
  • easily swap dataset versions with ml swap

changes

  • add cmd line option --installpath-data similar to --installpath-software
  • add cmd line option --subdir-data (default = data) similar to --subdir-software
  • add cmd line option --sourcepath-data similar to --sourcepath
  • add Easyconfig parameter data_sources similar to sources

design

  • the main reason for a separate subdir_data is reusability: in contrast to software it does not have to be rebuilt/reinstalled when for example upgrading the OS or building for a new architecture
  • the reason for a separate sourcepath_data is that datasets can be very large, so you may want to store them in a different file system or location.

@smoors smoors added the feature label Mar 3, 2024
@boegel boegel added this to the 4.x milestone Mar 13, 2024
Micket
Micket previously requested changes Mar 20, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needs adjusting
test_prefix_option:

def test_prefix_option(self):

test_show_config:

def test_show_config(self):

@boegel
Copy link
Member

boegel commented May 22, 2024

@smoors Let's re-target this to 5.0.x / EasyBuild 5.0, not because it involves breaking changes, but because it can serve as a "flagship" feature of EasyBuild 5.0 (seems a bit too much to introduce in a 4.9.x bug fix release)?

@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label May 22, 2024
@smoors smoors changed the base branch from develop to 5.0.x May 23, 2024 19:28
@boegel boegel changed the base branch from 5.0.x to develop March 19, 2025 10:53
@boegel boegel modified the milestones: 4.x, 5.x Mar 19, 2025
@boegel
Copy link
Member

boegel commented Mar 19, 2025

@smoors I changed to target branch in this PR from 5.0.x to develop, you should synchronize your PR branch with current develop branch (which has received a massive update after the release of EasyBuild v5.0.0, see #4825)

@boegel boegel modified the milestones: 5.x.x, 5.x Apr 9, 2025
@smoors smoors dismissed Micket’s stale review April 18, 2025 09:51

requested changes done

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. The changes are all to maintain alphabetical order.

@branfosj branfosj modified the milestones: 5.x, 5.0.1 May 7, 2025
@branfosj branfosj merged commit e1ee851 into easybuilders:develop May 7, 2025
46 of 47 checks passed
@branfosj branfosj mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants