Skip to content

Conversation

@smoors
Copy link
Contributor

@smoors smoors commented Mar 3, 2024

@smoors smoors added the new label Mar 3, 2024
ThomasHoffmann77 added a commit to ThomasHoffmann77/easybuild-easyconfigs that referenced this pull request Mar 11, 2024
@ThomasHoffmann77
Copy link
Contributor

@smoors Could you please rename to RFdiffusion to be consistent with #18359 naming?

@Micket Micket changed the title {bio}[system/system] RFDiffusion-models v1.1.0, RFDiffusion-schedules v1.1.0 {bio}[system/system] RFdiffusion-models v1.1.0, RFdiffusion-schedules v1.1.0 Oct 29, 2024
@smoors
Copy link
Contributor Author

smoors commented May 8, 2025

Test report by @smoors
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3246
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node601.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, AMD EPYC 9384X 32-Core Processor, Python 3.9.20
See https://gist.github.com/smoors/26855bb33a16c522f00f2bda16044711 for a full test report.

@smoors
Copy link
Contributor Author

smoors commented May 9, 2025

Test report by @smoors
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3246
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node600.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, AMD EPYC 9384X 32-Core Processor, Python 3.9.20
See https://gist.github.com/smoors/0f0cc04633c4c29b5b68ad26fbca2724 for a full test report.

@branfosj
Copy link
Member

branfosj commented May 9, 2025

Note for anyone else testing this: the five files in RFdiffusion-schedules/1.1.0 are identical, but with different names. This means that the object store method used deduplicates this to one file in the object store with five symlinks to it.

@branfosj
Copy link
Member

branfosj commented May 9, 2025

I suspect adding to https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/test/easyconfigs/easyconfigs.py#L1021 will fix

======================================================================
FAIL: test_downloadable_or_instructions (test.easyconfigs.easyconfigs.EasyConfigTest.test_downloadable_or_instructions)
Make sure the sources are downloadable or there are instructions for how to download them.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1045, in test_downloadable_or_instructions
    self.fail(error_msg % (len(problem_ecs), ', '.join(problem_ecs)))
AssertionError: 2 easyconfigs found without defined sources or download_instructions: /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/RFdiffusion-models/RFdiffusion-models-1.1.0.eb, /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/RFdiffusion-schedules/RFdiffusion-schedules-1.1.0.eb

easybuilders/easybuild-framework#4874 to fix

======================================================================
FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest.test_pr_sha256_checksums)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1182, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: False is not true : No checksum issues:
Checksums missing for one or more sources/patches in RFdiffusion-models-1.1.0.eb: found 0 sources + 0 patches vs 9 checksums
Checksums missing for one or more sources/patches in RFdiffusion-schedules-1.1.0.eb: found 0 sources + 0 patches vs 1 checksums

@smoors
Copy link
Contributor Author

smoors commented May 9, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20019 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20019 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6321

Test results coming soon (I hope)...

Details

- notification for comment with ID 2866510303 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/9d66fef8a11f258de2719820eafcb944 for a full test report.

@jfgrimm jfgrimm added this to the 5.0.1 milestone May 9, 2025
@jfgrimm
Copy link
Member

jfgrimm commented May 9, 2025

Going in, thanks @smoors!

@jfgrimm jfgrimm merged commit 995f150 into easybuilders:develop May 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants