Skip to content

Conversation

@branfosj
Copy link
Member

@branfosj branfosj commented May 8, 2025

fix for #4474 - 100.0 files to download.

If count_files() returns 0 then the Rich progress bar defaults to percentage - so 100.0 for the total.

Downloading Base_epoch8_ckpt.pt_v12fc204edeae5b57713c5ad7dcb97d39 ━━━━━━━━━━━━━━━━━━━━━━━━╺━━━━━━━━━━━━━━━ 294.6/483.6 MB 7.6 MB/s 0:00:25
Fetching files:   7% (7/100.0) ━━╸━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0:00:38 (Base_epoch8_ckpt.pt_v12fc204edeae5b57713c5ad7dcb97d39)

@branfosj branfosj added this to the 5.0.1 milestone May 8, 2025
Co-authored-by: Jasper Grimm <[email protected]>
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit 6950b51 into easybuilders:develop May 8, 2025
37 checks passed
@branfosj branfosj deleted the count branch May 8, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants