warn if non-single-letter local variables not named 'local_*' or '_*' are used + enhance --fix-deprecated-easyconfigs to rename them #2938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config_parameters' leaks into other tests
… variables to a dedicated function (which we can leverage later from fix_deprecated_easyconfigs)
…nfig files start with 'local_' or are single-letter
…bles not following expected naming scheme under --fix-deprecated-easyconfigs
houndci-bot
reviewed
Jun 26, 2019
…f dummy toolchain
… or not strict naming scheme for local variables in easyconfig files is enforced
houndci-bot
reviewed
Jun 26, 2019
houndci-bot
reviewed
Jun 26, 2019
boegel
changed the title
…nfigs and mark easyconfig as fixed so result actually gets written
…ed as a local variable
…naming scheme for local variables
This was referenced Aug 8, 2019
Merged
fix names of local variables in CUDA/GNU/gcccuda easyconfigs
easybuilders/easybuild-easyconfigs#8701
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfr. discussion in #2912
Marked
WIPsince it needs a bit more love before it can be considered complete, in particular:improve regular expression used to rename non-conforming local variables via--fix-deprecated-easyconfigslocal_*make enhanced test for--fix-deprecated-easyconfigspass