Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Aug 9, 2019

required to avoid warnings when these easyconfigs are parsed because of changed made in easybuilders/easybuild-framework#2938

@boegel boegel added this to the 4.0 milestone Aug 9, 2019
@boegel boegel force-pushed the fix_local_var_naming_g branch from 597f20a to cd34e0b Compare August 9, 2019 16:52
@boegel
Copy link
Member Author

boegel commented Aug 9, 2019

Test report by @boegel
SUCCESS
Build succeeded for 46 out of 46 (46 easyconfigs in this PR)
node2425.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/8a3d5daa4dd8c39f78d9b81894a51249 for a full test report.

@boegel boegel force-pushed the fix_local_var_naming_g branch from cd34e0b to 7fb3d66 Compare August 9, 2019 18:11
@easybuilders easybuilders deleted a comment from boegelbot Aug 9, 2019
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Aug 14, 2019

Going in, thanks @boegel!

@Micket Micket merged commit 9613473 into easybuilders:4.x Aug 14, 2019
@boegel boegel deleted the fix_local_var_naming_g branch August 15, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants