Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Aug 10, 2019

required to avoid warnings when these easyconfigs are parsed because of changed made in easybuilders/easybuild-framework#2938

@boegel boegel added this to the 4.0 milestone Aug 10, 2019
@boegel
Copy link
Member Author

boegel commented Aug 10, 2019

Test report by @boegel
SUCCESS
Build succeeded for 24 out of 24 (24 easyconfigs in this PR)
gligar05.gastly.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 2.7.5
See https://gist.github.com/7168f7dfaeaeb373096cd8f119c04dcb for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks even better to me

@Micket
Copy link
Contributor

Micket commented Aug 14, 2019

Going in, thanks @boegel!

@Micket Micket merged commit 8cbeced into easybuilders:4.x Aug 14, 2019
@boegel boegel deleted the fix_local_var_naming_n branch August 14, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants