[ros2-eloquent] Simulate initial acknack on ReaderProxy::start() [7974] #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
approved these changes
Mar 18, 2020
MiguelCompany
changed the title
Member
|
@mjcarroll @dirk-thomas Would someone please run a ROS2 CI build for this eloquent backport? |
|
|
Rebuilding network errors:
|
Member
|
@mjcarroll Are the failures unrelated to this PR? |
|
As far as Linux, yes, it looks like we keep losing our AWS instances for some reason. There are also some issues with the test reporting causing jobs to go unnecessarily red. Those should be solved by: ament/ament_cmake#229 and ament/ament_lint#222 Going through the results manually, I don't see anything that would cause me to believe it's related to this PR. |
mjcarroll
approved these changes
Mar 25, 2020
Member
Great! Merged then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1045