Simulate initial acknack on ReaderProxy::start() [7838] #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduPonz
changed the title
IkerLuengo
suggested changes
Mar 6, 2020
Contributor
IkerLuengo
left a comment
IkerLuengo
left a comment
There was a problem hiding this comment.
Change the comment on src/cpp/rtps/writer/ReaderProxy.cpp (lines 292-293) to reflect that the special case is now used on late joiners too.
Author
Comment updated in |
Member
|
Build status:
|
This was referenced Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the #1042 issue.
With it, as part of starting a
ReaderProxy, a call toacked_changes_set(SequenceNumber_t())is performed to simulate an initial acknack from the reader. This has the effect of setting the ReaderProxy's low mark to the writer's first available change, which avoids the writer need to iterate through all the changes 0 to low mark the first time it sends data to the reader.This is OK to do, since an initial heartbeat is sent to the reader notifying the writer's state right after discovery, which already tells the reader that the first change is low mark, so there is no need of sending any gap, nor requesting changes older than that.