[wasm][debugger] GetProperties broken on chrome #63403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsFix the implementation and how we test.
|
thaystg
changed the title
ilonatommy
approved these changes
Jan 5, 2022
Member
|
How was it broken? |
Member
|
I mean, in what way was it broken. |
Member
Author
|
As it wasn't returning an array as it's expected, when we try to expand the getters we are getting this as result: |
Member
Author
|
Wow, I think it would be better to pass NULL as the name value, so we would see something like this, which is more similar to VS: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #62627 we need to change the test and fix the implementation.