Skip to content

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Dec 10, 2021

ToDo - transform all the other schemes the same way as objects if possible:

  • Object - done in this PR
  • Scope - no need for separation, all scope values returned in result
  • ValueType - protected access modifier not handled, other values sorted into 3 groups - delegated to a separate issue [wasm][debugger] Separate public, private and internal structure properties #63082.
  • Arrays - no need for separation, all array elements returned in result
  • MethodId - method does not have public/private properties so all values can be returned in "result". Evaluation of methods calls returning an object/struct has already object/struct schematic assigned, not method.
  • Pointer - complex managed types (e.g. objects) cannot have a pointer. At the same time, simple types don't have public/private properties so all pointer values can be returned in "result".
  • Cfo_res - call function cache cannot have public/private properties, so all values are returned in "result".

ilonatommy and others added 30 commits November 25, 2021 11:26
@ilonatommy
Copy link
Member Author

To be merged after #62045.

@ilonatommy ilonatommy marked this pull request as ready for review January 3, 2022 12:56
@thaystg
Copy link
Member

thaystg commented Jan 3, 2022

@ilonatommy , can we see any difference in VS using this PR, does the icons change? Can you paste a picture here?
Something like this, differente icons for protected and private attributes?
image

@ilonatommy
Copy link
Member Author

ilonatommy commented Jan 3, 2022

@thaystg, I am pasting watch view from VS, they are not 100% the same as yours but there is a change in comparison to main, where all 4 icons look like pub/priv icons:
public-private

@ilonatommy ilonatommy removed the request for review from marek-safar January 3, 2022 13:14
@thaystg
Copy link
Member

thaystg commented Jan 3, 2022

@ilonatommy and debugging on chrome, do you see any different icon?

@ilonatommy
Copy link
Member Author

In Browser there are different colors of ink for priv/pub and protected/internal:
browser pub-priv

@thaystg
Copy link
Member

thaystg commented Jan 3, 2022

@ilonatommy I know that you changed the behavior of GetProperties to join Private and Internal to not break all the tests. But could you implement another version of GetProperties and add a new test checking if the values are added in the correct place (private and internal).

@ilonatommy ilonatommy merged commit ae2e360 into dotnet:main Jan 4, 2022
thaystg added a commit to thaystg/runtime that referenced this pull request Jan 5, 2022
ilonatommy pushed a commit that referenced this pull request Jan 6, 2022
* Fixing how we test and the implementation after #62627

* Passing null to name.
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants