-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Divide properties into: public, private, protected. #62627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divide properties into: public, private, protected. #62627
Conversation
Co-authored-by: Ankit Jain <[email protected]>
…dlers are Browsable.Never by default.
…sts.cs Co-authored-by: Ankit Jain <[email protected]>
…ommy/runtime into debugger-browse-attribute
…ld name to be consistant with the value.
|
To be merged after #62045. |
|
@ilonatommy , can we see any difference in VS using this PR, does the icons change? Can you paste a picture here? |
|
@thaystg, I am pasting watch view from VS, they are not 100% the same as yours but there is a change in comparison to main, where all 4 icons look like pub/priv icons: |
|
@ilonatommy and debugging on chrome, do you see any different icon? |
|
@ilonatommy I know that you changed the behavior of GetProperties to join Private and Internal to not break all the tests. But could you implement another version of GetProperties and add a new test checking if the values are added in the correct place (private and internal). |
* Fixing how we test and the implementation after #62627 * Passing null to name.



ToDo - transform all the other schemes the same way as objects if possible: