Skip to content

[wasm][debugger] GetProperties broken on chrome #63403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilonatommy merged 2 commits into from
Jan 6, 2022
Merged

[wasm][debugger] GetProperties broken on chrome #63403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
690ebe8
Fixing how we test and the implementation after #62627
thaystg Jan 5, 2022
58eae50
Passing null to name.
thaystg Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,8 +697,8 @@ internal async Task<JToken> RuntimeGetPropertiesInternal(SessionId id, DotnetObj
}
case "methodId":
{
var resMethod = await context.SdbAgent.InvokeMethodInObject(objectId.Value, objectId.SubValue, "", token);
return sortByAccessLevel ? JObject.FromObject(new { result = resMethod }) : new JArray(resMethod);
var resMethod = await context.SdbAgent.InvokeMethodInObject(objectId.Value, objectId.SubValue, null, token);
return sortByAccessLevel ? JObject.FromObject(new { result = new JArray(resMethod) }) : new JArray(resMethod);
}
case "object":
{
Expand Down
2 changes: 1 addition & 1 deletion src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ internal async Task CheckCustomType(JToken actual_val, JToken exp_val, string la
if (expectedValue.Type != JTokenType.Null)
{
var valueAfterRunGet = await GetProperties(get["objectId"]?.Value<string>());
await CheckValue(valueAfterRunGet["value"], expectedValue, exp_val["type_name"]?.Value<string>());
await CheckValue(valueAfterRunGet[0]["value"], expectedValue, exp_val["type_name"]?.Value<string>());
}
break;
}
Expand Down