Skip to content

[wasm][debugger] Sort properties by protection level in structures. #63339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ilonatommy wants to merge 7 commits into from
Closed

[wasm][debugger] Sort properties by protection level in structures. #63339

ilonatommy wants to merge 7 commits into from

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jan 4, 2022 •
edited
Loading

Fixes #63082 and is a continuation of #62627.

@ghost ghost added the area-Debugger-mono label Jan 4, 2022
@ghost ghost assigned ilonatommy Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Continuation of #62627

Author: ilonatommy
Assignees: ilonatommy
Labels:

area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Continuation of #62627

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy changed the title Sort properties by protection level in structures. [wasm][debugger] Sort properties by protection level in structures. Jan 4, 2022
@ilonatommy ilonatommy marked this pull request as ready for review January 5, 2022 09:34
@ilonatommy ilonatommy requested review from lambdageek and thaystg and removed request for marek-safar January 5, 2022 09:34
lambdageek
lambdageek reviewed Jan 5, 2022
View reviewed changes
@ilonatommy ilonatommy requested a review from lambdageek January 5, 2022 16:32
@ilonatommy ilonatommy added this to the 7.0.0 milestone Jan 6, 2022
@ilonatommy ilonatommy requested a review from radical January 10, 2022 13:22
thaystg
thaystg reviewed Jan 10, 2022
View reviewed changes
radical
radical requested changes Jan 11, 2022
View reviewed changes
@ghost ghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Jan 11, 2022
@ilonatommy ilonatommy requested a review from radical January 11, 2022 09:23
radical
radical reviewed Jan 11, 2022
View reviewed changes
radical
radical reviewed Jan 11, 2022
View reviewed changes
radical
radical reviewed Jan 11, 2022
View reviewed changes
@lewing lewing requested a review from radical February 15, 2022 15:12
@ilonatommy ilonatommy requested a review from lewing March 23, 2022 10:09
@ilonatommy ilonatommy force-pushed the structure-properties-internal-private branch from 90d15b5 to 88d5d7f Compare March 29, 2022 07:51
@ilonatommy ilonatommy force-pushed the structure-properties-internal-private branch from ff205b9 to 3ff5fcb Compare March 31, 2022 07:12
@ilonatommy ilonatommy force-pushed the structure-properties-internal-private branch from 3b74495 to 693c4f6 Compare April 4, 2022 08:31
@ilonatommy
Copy link
Member Author

ilonatommy commented Apr 4, 2022

/azp run runtime-staging

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 4, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

ilonatommy commented Apr 5, 2022

Staging of EvaluateOnCallFrameTests has a timeout but passes locally.

lewing
lewing reviewed Apr 5, 2022
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok but it only tests the value of the string now, do we have any tests for more complicated types?

@ilonatommy ilonatommy marked this pull request as draft April 6, 2022 11:59
@ilonatommy ilonatommy mentioned this pull request Apr 8, 2022
Closed
@ghost ghost added the no-recent-activity label Apr 20, 2022
@ghost
Copy link

ghost commented Apr 20, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ilonatommy ilonatommy mentioned this pull request Apr 25, 2022
Merged
@ilonatommy ilonatommy closed this Apr 25, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing left review comments

@thaystg thaystg thaystg left review comments

@lambdageek lambdageek Awaiting requested review from lambdageek

@radical radical Awaiting requested review from radical

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara will be requested when the pull request is marked ready for review pavelsavara is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommy ilonatommy

Labels

arch-wasm WebAssembly architecture area-Debugger-mono no-recent-activity

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[wasm][debugger] Separate public, private and internal structure properties

5 participants

@ilonatommy @radical @lewing @lambdageek @thaystg