Fix failures in internal validation pipeline #123452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes failures in the internal validation pipeline by adjusting Helix queue configurations for different platforms and adding support for private NuGet feed authentication in cross-platform jobs.
Changes:
- Modified Android queue selection logic to use Ubuntu-based queues for internal builds when Windows-based queues are unavailable
- Added public/internal queue differentiation for iOS, tvOS, Android, and Browser WASM platforms in CoreCLR template
- Added private NuGet feed credential setup for non-public builds in xplat-job template
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Modified Android queue selection to always use Ubuntu.2204 queue for internal builds and specific Android platforms, with a comment explaining the workaround |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Added conditional logic to select different Helix queues (with/without ".Open" suffix) based on whether the build is public or internal for multiple platforms |
| eng/pipelines/common/templates/runtimes/xplat-job.yml | Added steps to restore internal tools and configure private NuGet feed credentials for non-public builds, with platform-specific handling |
mmitche
reviewed
Jan 26, 2026
This was referenced Jan 27, 2026
Open
mmitche
approved these changes
Jan 27, 2026
Member
Author
|
/ba-g known scaleset failure |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
Contributor
|
@jkoritzinsky backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Set up feed credentials for internal validation PR pipeline
Applying: Fix the open/internal split for runtime helix queues
Using index info to reconstruct a base tree...
M eng/pipelines/coreclr/templates/helix-queues-setup.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/coreclr/templates/helix-queues-setup.yml
CONFLICT (content): Merge conflict in eng/pipelines/coreclr/templates/helix-queues-setup.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Fix the open/internal split for runtime helix queues
Error: The process '/usr/bin/git' failed with exit code 128 |
JulieLeeMSFT
pushed a commit
that referenced
this pull request
Feb 4, 2026
Fixes #123444 main PR #123452 # Description Fix internal validation pipeline so we can validate backflow from the VMR for internal/release/10.x. # Customer Impact None, infra only change # Regression None, infra only change # Testing <!-- What kind of testing has been done with the fix. --> # Risk <!-- Please assess the risk of taking this fix. Provide details backing up your assessment. --> # Package authoring no longer needed in .NET 9 IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123444