[release/10.0] Fix internal validation pipeline#123825
Merged
JulieLeeMSFT merged 1 commit intodotnet:release/10.0from Feb 4, 2026
Merged
[release/10.0] Fix internal validation pipeline#123825JulieLeeMSFT merged 1 commit intodotnet:release/10.0from
JulieLeeMSFT merged 1 commit intodotnet:release/10.0from
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes internal validation pipeline issues for .NET 10.0 by addressing incorrect helix queue usage and authentication problems for internal builds.
Changes:
- Replaced manual NuGet source authentication setup with centralized
enable-internal-sources.ymltemplate across multiple pipeline files - Added public/internal build distinctions for helix queue selection to ensure internal builds use appropriate queues
- Added
templatePathparameter support to enable different template paths for public vs. internal/official builds
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/libraries/run-test-job.yml | Added templatePath parameter; replaced manual NuGet credential setup with enable-internal-sources.yml template |
| eng/pipelines/libraries/helix-queues-setup.yml | Modified Android queue selection to use Ubuntu-based queue for all internal builds since Windows.11.Amd64.Android queue has no internal equivalent |
| eng/pipelines/diagnostics/runtime-diag-job.yml | Replaced manual NuGet credential setup with enable-internal-sources.yml template |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Added public/internal conditional logic for helix queues (iOS, Android, Browser WASM, tvOS platforms) |
| eng/pipelines/common/templates/runtimes/xplat-job.yml | Added enable-internal-sources.yml template call for authentication |
| eng/pipelines/common/global-build-job.yml | Replaced manual NuGet credential setup with enable-internal-sources.yml template |
jkoritzinsky
changed the title
hoyosjs
reviewed
Jan 31, 2026
This was referenced Jan 31, 2026
hoyosjs
approved these changes
Feb 2, 2026
Member
|
don't block on that if we do trim - it's more important to have a test base. |
Member
|
@jkoritzinsky, please check the test failures. |
Member
Author
|
Failures are unrelated to this change (no change in the public pipeline in this PR). |
Member
|
/ba-g Failures are unrelated to this change (no change in the public pipeline in this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123444
main PR #123452
Description
Fix internal validation pipeline so we can validate backflow from the VMR for internal/release/10.x.
Customer Impact
None, infra only change
Regression
None, infra only change
Testing
Risk
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.