Skip to content

[RyuJit/WASM] Create a WASM-targeting RyuJit #121341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2025
Merged

[RyuJit/WASM] Create a WASM-targeting RyuJit #121341

merged 6 commits into from
Nov 14, 2025

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Nov 4, 2025 •
edited
Loading

Notable build system changes:

  1. Not included in clr.alljits yet. Build with clr.wasmjit.

Notable factoring choices:

  1. Introduce some new target defines for features which WASM won't need,
    like fixed size register mask support and GCInfo based on code metadata.
  2. For this initial commit, the amount of changes has been intentionally
    minimized. In the future, more things will be moved around and ifdefed out.

Contributes to #121208.

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 4, 2025
@SingleAccretion SingleAccretion marked this pull request as draft November 4, 2025 16:55
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 4, 2025
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Nov 4, 2025
View reviewed changes
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Nov 4, 2025
View reviewed changes
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Nov 4, 2025
View reviewed changes
@SingleAccretion SingleAccretion changed the title [RuiJit/WASM] Create a WASM-targeting RyuJit [RuyJit/WASM] Create a WASM-targeting RyuJit Nov 4, 2025
@SingleAccretion SingleAccretion changed the title [RuyJit/WASM] Create a WASM-targeting RyuJit [RyuJit/WASM] Create a WASM-targeting RyuJit Nov 4, 2025
This was referenced Nov 4, 2025
Open
Open
@SingleAccretion SingleAccretion force-pushed the WasmJit branch 2 times, most recently from 1ceabfa to e47623b Compare November 4, 2025 20:08
SingleAccretion
SingleAccretion commented Nov 4, 2025
View reviewed changes
@SingleAccretion
Add clr.wasmjit to PR CI
4212737 
Alternatively, we can just go ahead and add it to alljits right now.
@SingleAccretion
Create a WASM-targeting RyuJit
15893ed 
Notable build system changes:
 1) Not included in clr.alljits yet. Build with clr.wasmjit.

Notable factoring choices:
 1) Introduce some new target defines for features which WASM won't need,
    like fixed size register mask support and GCInfo based on code metadata.
 2) For this initial commit, the amount of changes has been intentionally
    minimized. In the future, more things will be moved around and ifdefed
    out.
SingleAccretion
SingleAccretion commented Nov 5, 2025
View reviewed changes
SingleAccretion
SingleAccretion commented Nov 5, 2025
View reviewed changes
@SingleAccretion SingleAccretion marked this pull request as ready for review November 5, 2025 00:44
@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Nov 5, 2025

@dotnet/jit-contrib

@jkotas jkotas added the arch-wasm WebAssembly architecture label Nov 5, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Nov 5, 2025

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

jkotas
jkotas reviewed Nov 5, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Nov 5, 2025
Open
This was referenced Nov 5, 2025
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request Nov 6, 2025
Closed
@jkoritzinsky jkoritzinsky mentioned this pull request Nov 6, 2025
Open
@AndyAyersMS
Copy link
Member

AndyAyersMS commented Nov 11, 2025

Merged up to refresh the CI...

AndyAyersMS
AndyAyersMS approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked again and think this is good enough for us to get started.

@kg
Copy link
Member

kg commented Nov 12, 2025

Is it possible the SOS test failures on the cDAC lane are related to this?

kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Nov 12, 2025

Is it possible the SOS test failures on the cDAC lane are related to this?

It seems hard to see how that's the case, however, there is also not much to go on.

The failure happens during dotnet/diagnostics tests:

image

It seems we have another recent run failing in a similar manner (https://dev.azure.com/dnceng-public/public/_build/results?buildId=1200546&view=results):

kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg reviewed Nov 12, 2025
View reviewed changes
kg
kg approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your hard work on this!

@SingleAccretion SingleAccretion mentioned this pull request Nov 12, 2025
Open
@AndyAyersMS
Copy link
Member

AndyAyersMS commented Nov 13, 2025

One more merge now that CI is probably in better shape.

@build-analysis build-analysis bot mentioned this pull request Nov 13, 2025
Open
@AndyAyersMS
Copy link
Member

AndyAyersMS commented Nov 13, 2025

CI is happier overall but we crossed an GUID update and the new SPMI collection is lagging. So will hold off until we can get that running again.

@build-analysis build-analysis bot mentioned this pull request Nov 13, 2025
Open
3 tasks
@AndyAyersMS AndyAyersMS merged commit c84d65d into dotnet:main Nov 14, 2025
169 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@kg kg kg approved these changes

+2 more reviewers

@am11 am11 am11 left review comments

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SingleAccretion @AndyAyersMS @kg @am11 @huoyaoyuan @jkotas @AaronRobinsonMSFT