Skip to content

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Nov 12, 2025

This allows:

int add(int a, int b) => a + b;

to run until the NYI in codegen.

@adamperlin
Copy link
Contributor

@SingleAccretion I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

@SingleAccretion
Copy link
Contributor Author

I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

Sure!

(But do be prepared for them to perhaps change a bit in the course of the review.)

@adamperlin
Copy link
Contributor

adamperlin commented Nov 13, 2025

I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

Sure!

(But do be prepared for them to perhaps change a bit in the course of the review.)

Ok, that sounds good! I will be prepared that they may change and I'll check back during review!

@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib


enum CorInfoArch
{
CORINFO_ARCH_X86 = 0x014c,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be either fully decoupled from PE file arch constants, or we should define PE file constant for WASM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason I haven't updated the numbers is that it would require a Jit-EE GUID update. Worth it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to decouple it from PE file arches, we may want to match System.Runtime.InteropServices.Architecture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would require a Jit-EE GUID update. Worth it?

It is fine with me. I am not a fan of accumulating cruft to be cleaned up later to save JIT-EE GUID updates.

Copy link
Member

@am11 am11 Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jit-EE GUID update.

BTW, we don't need to switch to windows for it anymore. We can use src/coreclr/tools/Common/JitInterface/ThunkGenerator/gen.sh which syncs thunks and updates the GUID.

@am11 am11 added the arch-wasm WebAssembly architecture label Nov 15, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants