-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RyuJit/WASM] Crossgen2 integration and further factoring #121563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8fa4501 to
74c8293
Compare
74c8293 to
9c8ac6b
Compare
|
@SingleAccretion I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose? |
Sure! (But do be prepared for them to perhaps change a bit in the course of the review.) |
Ok, that sounds good! I will be prepared that they may change and I'll check back during review! |
Using CG2.
Addressing the factoring TODO.
9c8ac6b to
e0a74ba
Compare
|
@dotnet/jit-contrib |
src/coreclr/inc/corinfo.h
Outdated
|
|
||
| enum CorInfoArch | ||
| { | ||
| CORINFO_ARCH_X86 = 0x014c, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be either fully decoupled from PE file arch constants, or we should define PE file constant for WASM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason I haven't updated the numbers is that it would require a Jit-EE GUID update. Worth it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to decouple it from PE file arches, we may want to match System.Runtime.InteropServices.Architecture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would require a Jit-EE GUID update. Worth it?
It is fine with me. I am not a fan of accumulating cruft to be cleaned up later to save JIT-EE GUID updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jit-EE GUID update.
BTW, we don't need to switch to windows for it anymore. We can use src/coreclr/tools/Common/JitInterface/ThunkGenerator/gen.sh which syncs thunks and updates the GUID.
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This allows:
to run until the NYI in codegen.