Repository navigation
[vs17.11] Disable unavailable OptProf data - #14868
Merged
ViktorHofer merged 1 commit intoAug 28, 2026
Merged
Conversation
Stop applying unavailable optimization data and disable fresh OptProf collection on the servicing branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1eca2b3e-1d22-46f4-aa2c-327ca9861c34
AlesProkop
temporarily deployed
to
copilot-pat-pool
August 28, 2026 07:14 — with
GitHub Actions
Inactive
AlesProkop
temporarily deployed
to
copilot-pat-pool
August 28, 2026 07:14 — with
GitHub Actions
Inactive
AlesProkop
temporarily deployed
to
copilot-pat-pool
August 28, 2026 07:15 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the vs17.11 official pipeline configuration to avoid attempting OptProf-related steps (and associated optimization-data restore) when OptProf artifacts are unavailable, and bumps the servicing version.
Changes:
- Default
enableOptProftofalsein thevs17.11official pipeline. - Gate publishing the
MicroBuildOutputsartifact onenableOptProf. - Bump
VersionPrefixto17.11.67.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
eng/Versions.props |
Version bump for servicing (17.11.66 → 17.11.67). |
azure-pipelines/.vsts-dotnet-build-jobs.yml |
Prevent publishing MicroBuildOutputs when OptProf is disabled. |
.vsts-dotnet.yml |
Make OptProf collection opt-in by default on this branch. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
ViktorHofer
approved these changes
Aug 28, 2026
AR-May
requested changes
Aug 28, 2026
AR-May
approved these changes
Aug 28, 2026
This was referenced Aug 31, 2026
AlesProkop
added a commit
that referenced
this pull request
Aug 31, 2026
Depends on #14867. Related to #14868 and #14869. ### Context The latest `vs18.0` official build ([15150034](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=15150034&view=results)) fails before compilation while restoring optimization data: `No drops matching the specified prefix were returned` This servicing branch no longer has matching optimization data to apply and should no longer collect fresh OptProf data. ### Changes Made - Changed `enableOptProf` to default to `false`. - Kept the existing behavior that sets `SkipApplyOptimizationData=true` when OptProf collection is disabled, avoiding the unavailable-data restore. - Gated `OptProf - Publish Artifact: MicroBuildOutputs` because the bootstrapper output is not produced when collection is disabled. - Bumped `VersionPrefix` from `18.0.32` to `18.0.33`. ### Testing - Parsed `.vsts-dotnet.yml` and `azure-pipelines/.vsts-dotnet-build-jobs.yml` with `ConvertFrom-Yaml`. - Parsed `eng/Versions.props` as XML. - Confirmed the `MSBuild-OptProf` pipeline resolves `.opt-prof.yml` from `main`, where #14867 prevents artifact-less builds from triggering training. - End-to-end validation requires the official pipeline run. ### Notes - We can skip the OptProf because this branch only inserts into .NET SDK and not VS, so there is no risk of introducing a performance regressions in VS. Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb
AlesProkop
added a commit
that referenced
this pull request
Aug 31, 2026
Depends on #14867. Follows #14901. Related to #14868 and #14869. ### Context After the internal-tool restore failure fixed by #14901, the `vs18.6` official build reaches the same unavailable optimization-data restore affecting the other servicing branches: `No drops matching the specified prefix were returned` This servicing branch no longer has matching optimization data to apply and should no longer collect fresh OptProf data. ### Changes Made - Changed `enableOptProf` to default to `false`. - Kept the existing behavior that sets `SkipApplyOptimizationData=true` when OptProf collection is disabled, avoiding the unavailable-data restore. - Gated the `MicroBuildOutputs` artifact because the bootstrapper output is not produced when collection is disabled. - Moved the bootstrapper output into the OptProf-only artifact-move list so the build does not fail when that directory is absent. - Bumped `VersionPrefix` from `18.6.23` to `18.6.24`. ### Testing - Parsed `.vsts-dotnet.yml` and `azure-pipelines/.vsts-dotnet-build-jobs.yml` with `ConvertFrom-Yaml`. - Parsed `eng/Versions.props` as XML. - Confirmed the `MSBuild-OptProf` pipeline resolves `.opt-prof.yml` from `main`, where #14867 prevents artifact-less builds from triggering training. - End-to-end validation requires the official pipeline run. ### Notes - We can skip the OptProf because this branch only inserts into .NET SDK and not VS, so there is no risk of introducing a performance regressions in VS. Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #14867. Merge #14867 first so the downstream OptProf pipeline does not trigger for builds without OptProf artifacts.
Related to #14861.
Context
The latest
vs17.11official build (15107183) fails before compilation while restoring optimization data:No drops matching the specified prefix were returnedThe requested prefix is
OptimizationData/DotNet-msbuild-Trusted/vs17.11. Previous successfulvs17.11Windows builds used-officialSkipApplyOptimizationData true, and this servicing branch no longer needs to collect fresh OptProf data.Changes Made
enableOptProfto default tofalse.SkipApplyOptimizationData=truewhen OptProf collection is disabled, avoiding the unavailable-data restore.OptProf - Publish Artifact: MicroBuildOutputsonenableOptProfbecause the bootstrapper output is not produced when collection is disabled.VersionPrefixfrom17.11.66to17.11.67.Testing
.vsts-dotnet.ymlandazure-pipelines/.vsts-dotnet-build-jobs.ymlwithConvertFrom-Yaml.eng/Versions.propsas XML.Notes