Skip to content

[vs17.11] Disable unavailable OptProf data - #14868

Merged
ViktorHofer merged 1 commit into
dotnet:vs17.11from
AlesProkop:alesprokop/disable-optprof-vs17.11
Aug 28, 2026
Merged

ViktorHofer merged 1 commit into
dotnet:vs17.11from
AlesProkop:alesprokop/disable-optprof-vs17.11

Conversation

@AlesProkop

@AlesProkop AlesProkop commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

Depends on #14867. Merge #14867 first so the downstream OptProf pipeline does not trigger for builds without OptProf artifacts.

Related to #14861.

Context

The latest vs17.11 official build (15107183) fails before compilation while restoring optimization data:

No drops matching the specified prefix were returned

The requested prefix is OptimizationData/DotNet-msbuild-Trusted/vs17.11. Previous successful vs17.11 Windows builds used -officialSkipApplyOptimizationData true, and this servicing branch no longer needs to collect fresh OptProf data.

Changes Made

  • Changed enableOptProf to default to false.
  • Kept the existing behavior that sets SkipApplyOptimizationData=true when OptProf collection is disabled, avoiding the unavailable-data restore.
  • Gated OptProf - Publish Artifact: MicroBuildOutputs on enableOptProf because the bootstrapper output is not produced when collection is disabled.
  • Bumped VersionPrefix from 17.11.66 to 17.11.67.

Testing

  • Parsed .vsts-dotnet.yml and azure-pipelines/.vsts-dotnet-build-jobs.yml with ConvertFrom-Yaml.
  • Parsed eng/Versions.props as XML.
  • End-to-end validation requires the official pipeline run.

Notes

  • We can skip the OptProf because this branch only inserts into .NET SDK and not VS, so there is no risk of introducing a performance regressions in VS.

Stop applying unavailable optimization data and disable fresh OptProf collection on the servicing branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1eca2b3e-1d22-46f4-aa2c-327ca9861c34
Copilot AI lite review requested due to automatic review settings August 28, 2026 07:14
@AlesProkop
AlesProkop requested a review from a team as a code owner August 28, 2026 07:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the vs17.11 official pipeline configuration to avoid attempting OptProf-related steps (and associated optimization-data restore) when OptProf artifacts are unavailable, and bumps the servicing version.

Changes:

  • Default enableOptProf to false in the vs17.11 official pipeline.
  • Gate publishing the MicroBuildOutputs artifact on enableOptProf.
  • Bump VersionPrefix to 17.11.67.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/Versions.props Version bump for servicing (17.11.66 → 17.11.67).
azure-pipelines/.vsts-dotnet-build-jobs.yml Prevent publishing MicroBuildOutputs when OptProf is disabled.
.vsts-dotnet.yml Make OptProf collection opt-in by default on this branch.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread .vsts-dotnet.yml Resolved
Comment thread .vsts-dotnet.yml Resolved
@ViktorHofer
ViktorHofer merged commit 6c7594c into dotnet:vs17.11 Aug 28, 2026
16 of 17 checks passed
AlesProkop added a commit that referenced this pull request Aug 31, 2026
Depends on #14867.

Related to #14868 and #14869.

### Context

The latest `vs18.0` official build
([15150034](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=15150034&view=results))
fails before compilation while restoring optimization data:

`No drops matching the specified prefix were returned`

This servicing branch no longer has matching optimization data to apply
and should no longer collect fresh OptProf data.

### Changes Made

- Changed `enableOptProf` to default to `false`.
- Kept the existing behavior that sets `SkipApplyOptimizationData=true`
when OptProf collection is disabled, avoiding the unavailable-data
restore.
- Gated `OptProf - Publish Artifact: MicroBuildOutputs` because the
bootstrapper output is not produced when collection is disabled.
- Bumped `VersionPrefix` from `18.0.32` to `18.0.33`.

### Testing

- Parsed `.vsts-dotnet.yml` and
`azure-pipelines/.vsts-dotnet-build-jobs.yml` with `ConvertFrom-Yaml`.
- Parsed `eng/Versions.props` as XML.
- Confirmed the `MSBuild-OptProf` pipeline resolves `.opt-prof.yml` from
`main`, where #14867 prevents artifact-less builds from triggering
training.
- End-to-end validation requires the official pipeline run.
### Notes
- We can skip the OptProf because this branch only inserts into .NET SDK
and not VS, so there is no risk of introducing a performance regressions
in VS.

Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb
AlesProkop added a commit that referenced this pull request Aug 31, 2026
Depends on #14867.

Follows #14901. Related to #14868 and #14869.

### Context

After the internal-tool restore failure fixed by #14901, the `vs18.6`
official build reaches the same unavailable optimization-data restore
affecting the other servicing branches:

`No drops matching the specified prefix were returned`

This servicing branch no longer has matching optimization data to apply
and should no longer collect fresh OptProf data.

### Changes Made

- Changed `enableOptProf` to default to `false`.
- Kept the existing behavior that sets `SkipApplyOptimizationData=true`
when OptProf collection is disabled, avoiding the unavailable-data
restore.
- Gated the `MicroBuildOutputs` artifact because the bootstrapper output
is not produced when collection is disabled.
- Moved the bootstrapper output into the OptProf-only artifact-move list
so the build does not fail when that directory is absent.
- Bumped `VersionPrefix` from `18.6.23` to `18.6.24`.

### Testing

- Parsed `.vsts-dotnet.yml` and
`azure-pipelines/.vsts-dotnet-build-jobs.yml` with `ConvertFrom-Yaml`.
- Parsed `eng/Versions.props` as XML.
- Confirmed the `MSBuild-OptProf` pipeline resolves `.opt-prof.yml` from
`main`, where #14867 prevents artifact-less builds from triggering
training.
- End-to-end validation requires the official pipeline run.

### Notes
- We can skip the OptProf because this branch only inserts into .NET SDK
and not VS, so there is no risk of introducing a performance regressions
in VS.

Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — fecd3d35 Deployed Aug 28, 2026 by AlesProkop via conclusion #745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants