Repository navigation
[vs18.6] Disable unavailable OptProf data - #14903
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb
There was a problem hiding this comment.
🔵 Needs a closer look
Pull request overview
Disables OptProf collection by default on the vs18.6 servicing branch to avoid failing official builds that attempt to restore now-unavailable optimization data, while keeping the existing “skip apply optimization data when OptProf is off” behavior and adjusting artifact publishing/moving accordingly.
Changes:
- Defaulted
enableOptProftofalsefor the official pipeline and preserved theSkipApplyOptimizationData=trueoverride when OptProf is disabled. - Gated publishing of the
MicroBuildOutputsartifact and made the artifact-move script only expect/move the bootstrapper output when OptProf is enabled. - Bumped
VersionPrefixfrom18.6.23to18.6.24.
File summaries
| File | Description |
|---|---|
| eng/Versions.props | Bumps VersionPrefix to 18.6.24 for the servicing branch. |
| azure-pipelines/.vsts-dotnet-build-jobs.yml | Gates MicroBuildOutputs publishing and only moves OptProf-specific outputs when OptProf is enabled. |
| .vsts-dotnet.yml | Defaults enableOptProf to false and documents why for this servicing branch. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Review Summary
I found one blocking issue. enableOptProf now defaults to false, but Upload VSTS Drop in azure-pipelines/.vsts-dotnet-build-jobs.yml still runs unconditionally on successful builds. The steps that generate artifacts\VSSetup\$(BuildConfiguration)\Insertion are all gated on enableOptProf, so the new default can make the non-OptProf path fail by uploading a folder that was never created. Please gate that drop task the same way as the OptProf-producing steps.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
awmgmcpgpatchdiff.githubusercontent.com
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
Generated by Expert Code Review (on open) for #14903 · 31.1 AIC · ⌖ 5.09 AIC · ⊞ 5K
Comments that could not be inline-anchored
azure-pipelines/.vsts-dotnet-build-jobs.yml:174
enableOptProf now defaults to false, but Upload VSTS Drop still runs on every successful build. Because the VSSetup-producing steps above are all gated on enableOptProf, this task can try to upload artifacts\VSSetup\$(BuildConfiguration)\Insertion even when that folder was never produced, turning the new default into a build break for the non-OptProf path.
Depends on #14867.
Follows #14901. Related to #14868 and #14869.
Context
After the internal-tool restore failure fixed by #14901, the
vs18.6official build reaches the same unavailable optimization-data restore affecting the other servicing branches:No drops matching the specified prefix were returnedThis servicing branch no longer has matching optimization data to apply and should no longer collect fresh OptProf data.
Changes Made
enableOptProfto default tofalse.SkipApplyOptimizationData=truewhen OptProf collection is disabled, avoiding the unavailable-data restore.MicroBuildOutputsartifact because the bootstrapper output is not produced when collection is disabled.VersionPrefixfrom18.6.23to18.6.24.Testing
.vsts-dotnet.ymlandazure-pipelines/.vsts-dotnet-build-jobs.ymlwithConvertFrom-Yaml.eng/Versions.propsas XML.MSBuild-OptProfpipeline resolves.opt-prof.ymlfrommain, where Require ready-for-training tag for OptProf #14867 prevents artifact-less builds from triggering training.Notes