Skip to content

[vs18.6] Disable unavailable OptProf data - #14903

Merged
AlesProkop merged 1 commit into
dotnet:vs18.6from
AlesProkop:alesprokop/disable-optprof-vs18.6
Aug 31, 2026
Merged

AlesProkop merged 1 commit into
dotnet:vs18.6from
AlesProkop:alesprokop/disable-optprof-vs18.6

Conversation

@AlesProkop

@AlesProkop AlesProkop commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Depends on #14867.

Follows #14901. Related to #14868 and #14869.

Context

After the internal-tool restore failure fixed by #14901, the vs18.6 official build reaches the same unavailable optimization-data restore affecting the other servicing branches:

No drops matching the specified prefix were returned

This servicing branch no longer has matching optimization data to apply and should no longer collect fresh OptProf data.

Changes Made

  • Changed enableOptProf to default to false.
  • Kept the existing behavior that sets SkipApplyOptimizationData=true when OptProf collection is disabled, avoiding the unavailable-data restore.
  • Gated the MicroBuildOutputs artifact because the bootstrapper output is not produced when collection is disabled.
  • Moved the bootstrapper output into the OptProf-only artifact-move list so the build does not fail when that directory is absent.
  • Bumped VersionPrefix from 18.6.23 to 18.6.24.

Testing

  • Parsed .vsts-dotnet.yml and azure-pipelines/.vsts-dotnet-build-jobs.yml with ConvertFrom-Yaml.
  • Parsed eng/Versions.props as XML.
  • Confirmed the MSBuild-OptProf pipeline resolves .opt-prof.yml from main, where Require ready-for-training tag for OptProf #14867 prevents artifact-less builds from triggering training.
  • End-to-end validation requires the official pipeline run.

Notes

  • We can skip the OptProf because this branch only inserts into .NET SDK and not VS, so there is no risk of introducing a performance regressions in VS.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb
Copilot AI lite review requested due to automatic review settings August 31, 2026 08:17
@AlesProkop
AlesProkop requested a review from a team as a code owner August 31, 2026 08:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Pull request overview

Disables OptProf collection by default on the vs18.6 servicing branch to avoid failing official builds that attempt to restore now-unavailable optimization data, while keeping the existing “skip apply optimization data when OptProf is off” behavior and adjusting artifact publishing/moving accordingly.

Changes:

  • Defaulted enableOptProf to false for the official pipeline and preserved the SkipApplyOptimizationData=true override when OptProf is disabled.
  • Gated publishing of the MicroBuildOutputs artifact and made the artifact-move script only expect/move the bootstrapper output when OptProf is enabled.
  • Bumped VersionPrefix from 18.6.23 to 18.6.24.
File summaries
File Description
eng/Versions.props Bumps VersionPrefix to 18.6.24 for the servicing branch.
azure-pipelines/.vsts-dotnet-build-jobs.yml Gates MicroBuildOutputs publishing and only moves OptProf-specific outputs when OptProf is enabled.
.vsts-dotnet.yml Defaults enableOptProf to false and documents why for this servicing branch.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I found one blocking issue. enableOptProf now defaults to false, but Upload VSTS Drop in azure-pipelines/.vsts-dotnet-build-jobs.yml still runs unconditionally on successful builds. The steps that generate artifacts\VSSetup\$(BuildConfiguration)\Insertion are all gated on enableOptProf, so the new default can make the non-OptProf path fail by uploading a folder that was never created. Please gate that drop task the same way as the OptProf-producing steps.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • awmgmcpg
  • patchdiff.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "patchdiff.githubusercontent.com"

See Network Configuration for more information.

Generated by Expert Code Review (on open) for #14903 · 31.1 AIC · ⌖ 5.09 AIC · ⊞ 5K

Comments that could not be inline-anchored

azure-pipelines/.vsts-dotnet-build-jobs.yml:174

enableOptProf now defaults to false, but Upload VSTS Drop still runs on every successful build. Because the VSSetup-producing steps above are all gated on enableOptProf, this task can try to upload artifacts\VSSetup\$(BuildConfiguration)\Insertion even when that folder was never produced, turning the new default into a build break for the non-OptProf path.

@AlesProkop
AlesProkop enabled auto-merge (squash) August 31, 2026 08:54
@AlesProkop
AlesProkop merged commit 0934a9e into dotnet:vs18.6 Aug 31, 2026
18 checks passed

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — 1009f1f6 Deployed Aug 31, 2026 by AlesProkop via conclusion #775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants