Repository navigation
[vs18.0] Disable unavailable OptProf data - #14902
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Disables OptProf data collection by default on the vs18.0 servicing branch to avoid failing early in the official build when optimization data drops are unavailable, while preserving the existing “skip apply optimization data when OptProf is off” behavior.
Changes:
- Default
enableOptProftofalsein the official pipeline parameters, with comments explaining why. - Gate the
MicroBuildOutputsartifact publish step onenableOptProfto avoid publishing a non-existent bootstrapper output. - Bump
VersionPrefixto18.0.33.
File summaries
| File | Description |
|---|---|
| eng/Versions.props | Bumps VersionPrefix from 18.0.32 to 18.0.33 for the servicing branch. |
| azure-pipelines/.vsts-dotnet-build-jobs.yml | Gates OptProf - Publish Artifact: MicroBuildOutputs on enableOptProf. |
| .vsts-dotnet.yml | Defaults enableOptProf to false (with rationale) and passes the parameter through to the job template. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
| # | Dimension | Verdict |
|---|---|---|
| 1 | Backwards Compatibility Vigilance | 🔴 1 BLOCKING |
| 19 | Build Infrastructure Care | 🔴 1 BLOCKING |
✅ 22/24 dimensions clean.
- Disabling OptProf by default also suppresses the
MicroBuildOutputsartifact, but.opt-prof.ymlstill triggers onvs*builds and unconditionally downloads that artifact. This breaks the existing pipeline contract for servicing-branch builds.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpg
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
Generated by Expert Code Review (on open) for #14902 · 45.4 AIC · ⌖ 7.61 AIC · ⊞ 5K
This is handled by #1486. This PR disables the step that adds that tag, so normal vs18.0 builds do not fan out into OptProf and no consumer attempts to download MicroBuildOutputs .
Depends on #14867.
Related to #14868 and #14869.
Context
The latest
vs18.0official build (15150034) fails before compilation while restoring optimization data:No drops matching the specified prefix were returnedThis servicing branch no longer has matching optimization data to apply and should no longer collect fresh OptProf data.
Changes Made
enableOptProfto default tofalse.SkipApplyOptimizationData=truewhen OptProf collection is disabled, avoiding the unavailable-data restore.OptProf - Publish Artifact: MicroBuildOutputsbecause the bootstrapper output is not produced when collection is disabled.VersionPrefixfrom18.0.32to18.0.33.Testing
.vsts-dotnet.ymlandazure-pipelines/.vsts-dotnet-build-jobs.ymlwithConvertFrom-Yaml.eng/Versions.propsas XML.MSBuild-OptProfpipeline resolves.opt-prof.ymlfrommain, where Require ready-for-training tag for OptProf #14867 prevents artifact-less builds from triggering training.Notes