Skip to content

[vs18.0] Disable unavailable OptProf data - #14902

Merged
AlesProkop merged 1 commit into
dotnet:vs18.0from
AlesProkop:alesprokop/disable-optprof-vs18.0
Aug 31, 2026
Merged

AlesProkop merged 1 commit into
dotnet:vs18.0from
AlesProkop:alesprokop/disable-optprof-vs18.0

Conversation

@AlesProkop

@AlesProkop AlesProkop commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Depends on #14867.

Related to #14868 and #14869.

Context

The latest vs18.0 official build (15150034) fails before compilation while restoring optimization data:

No drops matching the specified prefix were returned

This servicing branch no longer has matching optimization data to apply and should no longer collect fresh OptProf data.

Changes Made

  • Changed enableOptProf to default to false.
  • Kept the existing behavior that sets SkipApplyOptimizationData=true when OptProf collection is disabled, avoiding the unavailable-data restore.
  • Gated OptProf - Publish Artifact: MicroBuildOutputs because the bootstrapper output is not produced when collection is disabled.
  • Bumped VersionPrefix from 18.0.32 to 18.0.33.

Testing

  • Parsed .vsts-dotnet.yml and azure-pipelines/.vsts-dotnet-build-jobs.yml with ConvertFrom-Yaml.
  • Parsed eng/Versions.props as XML.
  • Confirmed the MSBuild-OptProf pipeline resolves .opt-prof.yml from main, where Require ready-for-training tag for OptProf #14867 prevents artifact-less builds from triggering training.
  • End-to-end validation requires the official pipeline run.

Notes

  • We can skip the OptProf because this branch only inserts into .NET SDK and not VS, so there is no risk of introducing a performance regressions in VS.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 90868941-d32d-4372-a49c-c889de6a0ecb
Copilot AI lite review requested due to automatic review settings August 31, 2026 08:17
@AlesProkop
AlesProkop requested a review from a team as a code owner August 31, 2026 08:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Pull request overview

Disables OptProf data collection by default on the vs18.0 servicing branch to avoid failing early in the official build when optimization data drops are unavailable, while preserving the existing “skip apply optimization data when OptProf is off” behavior.

Changes:

  • Default enableOptProf to false in the official pipeline parameters, with comments explaining why.
  • Gate the MicroBuildOutputs artifact publish step on enableOptProf to avoid publishing a non-existent bootstrapper output.
  • Bump VersionPrefix to 18.0.33.
File summaries
File Description
eng/Versions.props Bumps VersionPrefix from 18.0.32 to 18.0.33 for the servicing branch.
azure-pipelines/.vsts-dotnet-build-jobs.yml Gates OptProf - Publish Artifact: MicroBuildOutputs on enableOptProf.
.vsts-dotnet.yml Defaults enableOptProf to false (with rationale) and passes the parameter through to the job template.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Dimension Verdict
1 Backwards Compatibility Vigilance 🔴 1 BLOCKING
19 Build Infrastructure Care 🔴 1 BLOCKING

✅ 22/24 dimensions clean.

  • Disabling OptProf by default also suppresses the MicroBuildOutputs artifact, but .opt-prof.yml still triggers on vs* builds and unconditionally downloads that artifact. This breaks the existing pipeline contract for servicing-branch builds.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Expert Code Review (on open) for #14902 · 45.4 AIC · ⌖ 7.61 AIC · ⊞ 5K

@AlesProkop
AlesProkop dismissed github-actions[bot]’s stale review August 31, 2026 08:54

This is handled by #1486. This PR disables the step that adds that tag, so normal  vs18.0  builds do not fan out into OptProf and no consumer attempts to download  MicroBuildOutputs .

@AlesProkop
AlesProkop enabled auto-merge (squash) August 31, 2026 08:54
@AlesProkop
AlesProkop merged commit af2509a into dotnet:vs18.0 Aug 31, 2026
17 checks passed

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — 5e1035aa Deployed Aug 31, 2026 by AlesProkop via conclusion #774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants