Skip to content

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Mar 4, 2024

- What I did

  • Updated gha runners to ubuntu-22.04
  • Updated e2e test matrix to test against 23-dind, 24-dind and 25-dind versions of the engine
  • Small adjustments to some tests because of the engine upgrade (engine output text + cgroups checking)
  • Temporarily skipping a problematic test (until a fix on moby is released)

- How I did it
magic

- How to verify it
CI tests are green

- A picture of a cute animal (not mandatory but encouraged)
TBD

@vvoland vvoland added this to the 25.0.4 milestone Mar 4, 2024
@vvoland vvoland self-assigned this Mar 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Merging #4915 (d258282) into 25.0 (a25a910) will not change coverage.
Report is 11 commits behind head on 25.0.
The diff coverage is n/a.

❗ Current head d258282 differs from pull request most recent head 956d15c. Consider uploading reports for the commit 956d15c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             25.0    #4915   +/-   ##
=======================================
  Coverage   61.35%   61.35%           
=======================================
  Files         287      287           
  Lines       20088    20088           
=======================================
  Hits        12324    12324           
  Misses       6870     6870           
  Partials      894      894           

@thaJeztah
Copy link
Member

Need to backport #4873 as well

vvoland and others added 3 commits March 5, 2024 09:56
Allow tests to check the negotiated API version used by the client.

Can be used to skip tests based on API versions, for example:
```go
    skip.If(t, versions.LessThan(environment.DaemonAPIVersion(t), "1.44"))
```

will skip the test if the API version is older than 1.44

Signed-off-by: Paweł Gronowski <[email protected]>
(cherry picked from commit 9831fea)
Signed-off-by: Paweł Gronowski <[email protected]>
- gha runners updated to ubuntu 22.04
- e2e now runs against moby 23.0, 24.0 and 25.0
- temporarily skip broken test for moby < 25

Signed-off-by: Christopher Petito <[email protected]>
(cherry picked from commit 6b67b95)
Signed-off-by: Paweł Gronowski <[email protected]>
Signed-off-by: Christopher Petito <[email protected]>
(cherry picked from commit 69ed658)
Signed-off-by: Paweł Gronowski <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f783e8d into docker:25.0 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants