Skip to content

Conversation

@thaJeztah
Copy link
Member

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

Ah, fun; I guess we need to update the engine that's used, which is still on some very old version;

Engine:
  Version:          19.03.14

That version doesn't like cgroups v2;

=== FAIL: e2e/container TestAttachExitCode (0.87s)
    attach_test.go:15: assertion failed: 
        Command:  docker run -d -i --rm registry:5000/alpine:frozen sh -c read; exit 21
        ExitCode: 125
        Error:    exit status 125
        Stdout:   aa2bb27139717fd522a124f12c0b56f9d865ed659692b70bc776ab24ff3d3b5c
        
        Stderr:   docker: Error response from daemon: cgroups: cgroup mountpoint does not exist: unknown.
        
        
        Failures:
        ExitCode was 125 expected 0
        Expected no error

But updating the engine was causing some other tests to fail 😅

@thaJeztah thaJeztah changed the title gha: update runners to macOS 12, Ubuntu 22.04 gha: update runners to Ubuntu 22.04 Jan 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Merging #4793 (680abfd) into master (a1bd689) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4793   +/-   ##
=======================================
  Coverage   59.58%   59.58%           
=======================================
  Files         287      287           
  Lines       24722    24722           
=======================================
  Hits        14731    14731           
  Misses       9106     9106           
  Partials      885      885           

@krissetto krissetto mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants