-
Notifications
You must be signed in to change notification settings - Fork 2.1k
e2e: update engine version #3128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
535cab6 to
b60249b
Compare
b60249b to
a2ef375
Compare
a2ef375 to
7375341
Compare
a3573ae to
090faf0
Compare
Member
Author
Details |
Member
|
Looks the same as #3320 (comment) |
Member
Author
|
Yes, I remembered we still had to do this when I was updating the go version 😂, so I thought: let me rebase this one |
090faf0 to
c08e111
Compare
c08e111 to
f99705a
Compare
Member
Author
|
Failures: e2e (non-experimental, alpine, 20.10-dind)e2e (non-experimental, bullseye, 20.10-dind)e2e (experimental, alpine, 20.10-dind)e2e (experimental, bullseye, 20.10-dind) |
The stable-dind image was stuck on Docker 19.03. Updating to "dind" now gives us docker 20.10. Docker 20.10 fixed an issue with the "docker pull" response previously not including the image name of the image that was pulled. This caused the test to fail, as the .golden file no longer matched. Signed-off-by: Sebastiaan van Stijn <[email protected]>
f99705a to
76e4ef4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits for details