-
Notifications
You must be signed in to change notification settings - Fork 2.1k
use our own version of text/tabwriter #3568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
45fa617 to
5ca5122
Compare
|
LOL. wanted to post before/after, but looks like GitHub doesn't render it correctly. So with screenshots; Before: After: Looks like I should check with the Docker Hub team on the sorting BTW; I removed client-side sorting in #3470 (as the result from hub should be in the correct order), but looking at that output, I'm not sure what sorting is used there (at least it's not sorted by |
Signed-off-by: Nicolas De Loof <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3568 +/- ##
==========================================
+ Coverage 58.99% 59.36% +0.37%
==========================================
Files 282 285 +3
Lines 23813 24097 +284
==========================================
+ Hits 14049 14306 +257
- Misses 8908 8930 +22
- Partials 856 861 +5 |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
I also noticed my example output is not well formed on GitHub preview. Seems there's no definitive answer to this issue (other than: get everyone on earth speak French) |
So apparently, it's sorted by |


closes ##3421
supersede #3468
- What I did
add support for tab output with non-Latin characters
- How I did it
use a tabwriter for and relie on mattn/go-runewidth to compute columns width
- How to verify it
- Description for the changelog
docker tab-aligned output supports non-Latin characters
- A picture of a cute animal (not mandatory but encouraged)
