cli/tabwriter: Remove usage of runewidth with utf8 #5749
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed a while ago when implementing the
docker images --treebut forgot about posting:Align with upstream implementation: https://github.com/golang/go/blob/6da16013ba4444e0d71540f68279f0283a92d05d/src/text/tabwriter/tabwriter.go#L417
This allows us to drop the dependency on
mattn/go-runewidthpackage.Also,
runewidthdoesn't actually provide correct results in some cases.For comparison:
In this case, the "thumbs up" emoji takes one cell, so its width should be equal to1.Actually, the correct value is
2as it actually takes two cells!