fix: Remove argocd server calls for Application resources (Manifest, Event, Logs, Terminal) #3200
Conversation
|
SonarCloud Quality Gate failed.
|
| v, vars := r.URL.Query(), mux.Vars(r) | ||
| request := &ResourceRequestBean{} | ||
| podName := vars["podName"] | ||
| /*sinceSeconds, err := strconv.Atoi(v.Get("sinceSeconds")) |
There was a problem hiding this comment.
Please remove these comments
There was a problem hiding this comment.
this was already there prior my development. Should I remove !!
util/k8s/k8sApplicationService.go
Outdated
| if appId != "" { | ||
| // Validate App Type | ||
| appType, err := strconv.Atoi(v.Get("appType")) | ||
| if err != nil || appType < DevtronAppType || appType > HelmAppType { |
There was a problem hiding this comment.
please use !=, and at subsequent places
* minor-change * conditional break fixed * changing names
* acd app delete with non-cascade * handled DeleteErrorResponse length error * added go routine * argo non-casecade delete for helm and devtron app * fix: api response for cluster connection error * fix: nil pointer for cluster details * fix: updated test interface for pipeline * fix: non-cascade delete condition * fix: forceDelete and cascadeDelete validation * fix: delete response for force delete req * fix: added clusterName to res * fix: added clusterName to cluster-conn api resp * fix: updated non-cascade api resp * fix: updated non-cascade api err return * fix: updated chart list delete bug * fix: installed app delete bug * fix: installed app noncascade delete bug * fix: helm release force delete * fix: appstore release force delete * fix: appstore deployment list response * fix: bulk delete deployment api condition * fixed typo and response message * fix: bulk delete cd pipeline api payload * fix: logger and conditional chain * updated wire * modifed cluster services
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 141558 | Generic High Entropy Secret | 7bbd2a7 | scripts/devtron-reference-helm-charts/cronjob-chart_1-5-0/env-values.yaml | View secret |
| 2763127 | Generic High Entropy Secret | 7bbd2a7 | scripts/devtron-reference-helm-charts/cronjob-chart_1-5-0/secrets-test-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Ash-exp
changed the title
|
SonarCloud Quality Gate failed.
|
Description
Here. we are removing argocd server call dependencies for App resources (Manifest, Event, Terminal, Logs). But with existing kubelink APIs we are only checking helm deployment resource access whereas this api is being used in devtron apps and now will be used for gitops deployed resources too.
Here I have updated with conditional rbac depending on where the call came from and enforcing the rbac policies accordingly.
Set in default deployment type as GitOps if InternalUse is not configured.
Fix #3537
This will go along with PR #devtron-labs/dashboard#882
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?