feat: logs prev container #3469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash100198
requested changes
Jun 6, 2023
| TailLines int `json:"tailLines"` | ||
| Follow bool `json:"follow"` | ||
| ContainerName string `json:"containerName"` | ||
| PrevContainerLogs bool `json:"previous"` |
There was a problem hiding this comment.
By looking at variable name it does not strike as boolean value, please name it appropriately. maybe isPrevContainerLogsEnabled or any other name like this.
util/k8s/k8sApplicationService.go
Outdated
| TailLines: tailLines, | ||
| Follow: follow, | ||
| ContainerName: containerName, | ||
| PrevContainerLogs: isPrevLogs, |
There was a problem hiding this comment.
change here accordingly
|
SonarCloud Quality Gate failed.
|
prakash100198
approved these changes
Jun 8, 2023
Ash-exp
added a commit
that referenced
this pull request
Jun 21, 2023
…Event, Logs, Terminal) (#3200) * argocd rbac policy enforcement for kubelink * updated rbac for k8s resource * updated terminal rbac policy for helm app * removed deployment type * Updated TODO & ResourceValidation for devtron app * updated TODO * terminal rbac fixed * fixed cluster id bug for resource browser * fixed pod log bug * fix: deploymentType Validation condition * fix: Pod Logs Bug * feat: logs prev container (#3469) * minor-change * conditional break fixed * changing names * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * fix: App delete from ACD with non cascade (#3339) * acd app delete with non-cascade * handled DeleteErrorResponse length error * added go routine * argo non-casecade delete for helm and devtron app * fix: api response for cluster connection error * fix: nil pointer for cluster details * fix: updated test interface for pipeline * fix: non-cascade delete condition * fix: forceDelete and cascadeDelete validation * fix: delete response for force delete req * fix: added clusterName to res * fix: added clusterName to cluster-conn api resp * fix: updated non-cascade api resp * fix: updated non-cascade api err return * fix: updated chart list delete bug * fix: installed app delete bug * fix: installed app noncascade delete bug * fix: helm release force delete * fix: appstore release force delete * fix: appstore deployment list response * fix: bulk delete deployment api condition * fixed typo and response message * fix: bulk delete cd pipeline api payload * fix: logger and conditional chain * updated wire * modifed cluster services * reverted to devtron chart values * reverted migrator changes * fix: deployment app type for internal use false --------- Co-authored-by: rish2320 <[email protected]> Co-authored-by: ReleaseBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We will be able to see the logs of previous container.
Fixes #2882
How Has This Been Tested?
Tested all the cases manually.
Checklist: