fix: Remove argocd server calls for Application resources (Manifest, Event, Logs, Terminal)

api/helm-app/HelmAppService.go

@@ -795,12 +795,15 @@ func (impl *HelmAppServiceImpl) DecodeAppId(appId string) (*AppIdentifier, error
 	if len(component) != 3 {
 		return nil, fmt.Errorf("malformed app id %s", appId)
 	}
-	clustewrId, err := strconv.Atoi(component[0])
+	clusterId, err := strconv.Atoi(component[0])
 	if err != nil {
 		return nil, err
 	}
+	if clusterId <= 0 {
+		return nil, fmt.Errorf("target cluster is not provided")
+	}
 	return &AppIdentifier{
-		ClusterId:   clustewrId,
+		ClusterId:   clusterId,
 		Namespace:   component[1],
 		ReleaseName: component[2],
 	}, nil

client/k8s/application/Application.go

@@ -54,10 +54,11 @@ type K8sRequestBean struct {
 }
 
 type PodLogsRequest struct {
-	SinceTime     *metav1.Time `json:"sinceTime,omitempty"`
-	TailLines     int          `json:"tailLines"`
-	Follow        bool         `json:"follow"`
-	ContainerName string       `json:"containerName"`
+	SinceTime                  *metav1.Time `json:"sinceTime,omitempty"`
+	TailLines                  int          `json:"tailLines"`
+	Follow                     bool         `json:"follow"`
+	ContainerName              string       `json:"containerName"`
+	IsPrevContainerLogsEnabled bool         `json:"previous"`
 }
 
 type ResourceIdentifier struct {
@@ -236,6 +237,7 @@ func (impl K8sClientServiceImpl) GetPodLogs(ctx context.Context, restConfig *res
 		TailLines:  &tailLines,
 		Container:  podLogsRequest.ContainerName,
 		Timestamps: true,
+		Previous:   podLogsRequest.IsPrevContainerLogsEnabled,
 	}
 	if podLogsRequest.SinceTime != nil {
 		podLogOptions.SinceTime = podLogsRequest.SinceTime

pkg/appStore/deployment/service/AppStoreDeploymentService.go

@@ -221,7 +221,13 @@ func (impl AppStoreDeploymentServiceImpl) AppStoreDeployOperationDB(installAppVe
 	//		installedAppModel.DeploymentAppType = util.PIPELINE_DEPLOYMENT_TYPE_HELM
 	//	}
 	//}
-
+	if !isInternalUse {
+		if isGitOpsConfigured && appInstallationMode == util2.SERVER_MODE_FULL {
+			installAppVersionRequest.DeploymentAppType = util.PIPELINE_DEPLOYMENT_TYPE_ACD
+		} else {
+			installAppVersionRequest.DeploymentAppType = util.PIPELINE_DEPLOYMENT_TYPE_HELM
+		}
+	}
 	if installAppVersionRequest.DeploymentAppType == "" {
 		if isGitOpsConfigured {
 			installAppVersionRequest.DeploymentAppType = util.PIPELINE_DEPLOYMENT_TYPE_ACD

pkg/pipeline/PipelineBuilder.go

@@ -1749,6 +1749,13 @@ func (impl PipelineBuilderImpl) SetPipelineDeploymentAppType(pipelineCreateReque
 	//}
 
 	for _, pipeline := range pipelineCreateRequest.Pipelines {
+		if !impl.deploymentConfig.IsInternalUse {
+			if isGitOpsConfigured {
+				pipeline.DeploymentAppType = util.PIPELINE_DEPLOYMENT_TYPE_ACD
+			} else {
+				pipeline.DeploymentAppType = util.PIPELINE_DEPLOYMENT_TYPE_HELM
+			}
+		}
 		if pipeline.DeploymentAppType == "" {
 			if isGitOpsConfigured {
 				pipeline.DeploymentAppType = util.PIPELINE_DEPLOYMENT_TYPE_ACD

util/ValidatorHelper.go

@@ -232,7 +232,7 @@ func AutoScale(dat map[string]interface{}) (bool, error) {
 	if dat["kedaAutoscaling"] != nil {
 		kedaAutoScale, ok := dat["kedaAutoscaling"].(map[string]interface{})["enabled"]
 		if ok {
-			kedaAutoScaleEnabled=kedaAutoScale.(bool)
+			kedaAutoScaleEnabled = kedaAutoScale.(bool)
 		}
 	}
 	if dat["autoscaling"] != nil {