Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Additional Artifact Review RequiredChanges to artifact directory files requires at least 2 approvals from core team members. |
| docs = patch.config.get("docs") or patch.docs | ||
|
|
||
| # config inherits from HasConfig which is a dict so we need to cast it to Docs | ||
| if isinstance(docs, dict): |
There was a problem hiding this comment.
This could be handled by defining UnparsedMacroUpdate.config with docs: Docs as well but that breaks the pattern of only needing to inherit from HasColumns.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12559 +/- ##
==========================================
- Coverage 91.39% 90.47% -0.92%
==========================================
Files 203 203
Lines 25494 25586 +92
==========================================
- Hits 23301 23150 -151
- Misses 2193 2436 +243
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The failing integration tests are due to addition of a top level property |
| macro.meta = patch.meta | ||
| macro.docs = patch.docs | ||
|
|
||
| meta = {**(patch.meta or {}), **(patch.config.get("meta") or {})} |
There was a problem hiding this comment.
To keep the behaviour consistent with how its handled in exposures - see: #11589
|
This should have no impact to state:modified given dbt-core/core/dbt/contracts/graph/nodes.py Lines 1186 to 1196 in 4deee3c |
Resolves #12383
Resolves #9447
Problem
At present we can only declare meta and docs properties on top level whereas they should be supported inside the config as well.
Solution
Create config property with meta and docs and populate them in patch parser with precedence to
config.metaandconfig.docs.Checklist