-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Open
Labels
Impact: CAbugSomething isn't workingSomething isn't workingdep warningsuser docs[docs.getdbt.com] Needs better documentation[docs.getdbt.com] Needs better documentation
Description
Housekeeping
- I am a maintainer of dbt-core
Short description
The old/deprecated way of having meta was putting it directly on a node. However, awhile back we deprecated that paradigm and moved to nesting meta under a node's config. For reasoning I am not aware of, this never made it to Macro nodes. We should begin supporting the "best practice" path
Acceptance criteria
- Macro nodes have a meta property under their config property
- During parsing, flat meta specifications should end up under the
config.meta
Suggested Tests
- Macro meta can be specified in the
dbt_project.yamlconfig specification - In a macro definition, people can specify meta directly on an macro or under a macro's config, both should end up in the macro's
config.meta
Impact to Other Teams
Change impacts Artifacts team (change to the artifacts)
Will backports be required?
No
Context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Impact: CAbugSomething isn't workingSomething isn't workingdep warningsuser docs[docs.getdbt.com] Needs better documentation[docs.getdbt.com] Needs better documentation