Skip to content

Fix #11428: Add tags and meta config to exposures#11589

Merged
aranke merged 5 commits intomainfrom
fix_11428
May 9, 2025
Merged

Fix #11428: Add tags and meta config to exposures#11589
aranke merged 5 commits intomainfrom
fix_11428

Conversation

@aranke
Copy link
Contributor

@aranke aranke commented May 8, 2025

Resolves #11428

Problem

meta and tags specified in dbt_project.yml weren't flowing down to the exposure

Solution

Combine meta and tags between global config in dbt_project.yml and local config in properties.yml.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label May 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Additional Artifact Review Required

Changes to artifact directory files requires at least 2 approvals from core team members.

@aranke aranke added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label May 8, 2025
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (a5ec58d) to head (a820f0b).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11589      +/-   ##
==========================================
- Coverage   88.83%   88.81%   -0.03%     
==========================================
  Files         197      197              
  Lines       24784    24790       +6     
==========================================
- Hits        22018    22016       -2     
- Misses       2766     2774       +8     
Flag Coverage Δ
integration 85.81% <100.00%> (-0.03%) ⬇️
unit 62.85% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.85% <33.33%> (-0.01%) ⬇️
Integration Tests 85.81% <100.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aranke aranke marked this pull request as ready for review May 8, 2025 16:11
@aranke aranke requested a review from a team as a code owner May 8, 2025 16:11
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aranke aranke merged commit fe9c78e into main May 9, 2025
60 of 61 checks passed
@aranke aranke deleted the fix_11428 branch May 9, 2025 18:17
QMalcolm pushed a commit that referenced this pull request May 14, 2025
* Fix #11428: Add tags and meta config to exposures

* Add tags and meta to unit test

* Fix manifest integration test

* change meta order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Add support for setting tags and meta for exposures in dbt_project.yml

2 participants