Update CodeCov upload step in CI #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looking at the CI failures they all seem one off. @charlesbluca , the changes look fine, CI is failing all be it erroneously. You fine with me merging this? |
Collaborator
Author
|
I resolved the failures with #668, so maybe once that is in we can merge upstream here and verify that things are working as expected? |
Collaborator
|
@charlesbluca you wanna merge this with upstream now that #668 or me? |
Codecov Report
@@ Coverage Diff @@
## main #666 +/- ##
==========================================
+ Coverage 88.48% 88.62% +0.14%
==========================================
Files 69 69
Lines 3507 3507
Branches 710 710
==========================================
+ Hits 3103 3108 +5
+ Misses 317 308 -9
- Partials 87 91 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple changes to our CodeCov upload step in CI:
tokenparam, which shouldn't be necessary for public repos (and doesn't save us from unexpected 404 errors)fail_ci_if_errorso that if are unable to upload the report for some reason it won't register tests as failing