Generalize analyze/sample tests to resolve CI failures #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
==========================================
+ Coverage 88.48% 88.62% +0.14%
==========================================
Files 69 69
Lines 3507 3507
Branches 710 710
==========================================
+ Hits 3103 3108 +5
+ Misses 317 308 -9
- Partials 87 91 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like CI failures cropped up with the release of Dask 2022.8.0, which I imagine made some subtle changes to the behavior of
Series.quantileandDataFrame.sample.The broken tests both were doing some pretty specific checks that didn't seem too resistant to breakage (e.g. asserting the exact value / length for fixed random results), so I went ahead and reimplemented these tests so that instead of checking against given values, we are now asserting that dask-sql's implementation matches that of Dask, which should hopefully make it so these tests don't fail as often moving forward.