Use PyErrs for all Python-facing methods in dask_planner
#662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
requested review from
ayushdg,
galipremsagar and
jdye64
as code owners
Collaborator
|
This would also resolve #510 |
Codecov Report
@@ Coverage Diff @@
## datafusion-sql-planner #662 +/- ##
=========================================================
Coverage ? 65.70%
=========================================================
Files ? 73
Lines ? 3636
Branches ? 754
=========================================================
Hits ? 2389
Misses ? 1098
Partials ? 149 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jdye64
requested changes
Aug 4, 2022
Collaborator
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
This has been long due. Thanks for taking it on
jdye64
approved these changes
Aug 8, 2022
Collaborator
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
Long overdue and much appreciated!
Collaborator
|
I'm going to merge this since the failures are simply codecov failing to upload. Thanks again @charlesbluca |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up on reviews I received in #656, this PR replaces the
paniccalls within Python-facing methods indask_plannerand replaces them withErr(PyErr)), making modifications to signatures and logic where necessary to get this working.This PR also adds/modifies the custom exceptions so that they can be used throughout the codebase instead of
PyErr::new.