[DF] Add support for CREATE TABLE | VIEW AS statements
#656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
requested review from
ayushdg,
galipremsagar and
jdye64
as code owners
charlesbluca
commented
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## datafusion-sql-planner #656 +/- ##
=========================================================
Coverage ? 66.13%
=========================================================
Files ? 73
Lines ? 3635
Branches ? 754
=========================================================
Hits ? 2404
Misses ? 1081
Partials ? 150 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ayushdg
requested changes
Aug 3, 2022
Collaborator
ayushdg
left a comment
ayushdg
left a comment
There was a problem hiding this comment.
Minor suggestions but generally things lgtm!
| Some(create_memory_table) => Ok(format!("{}", create_memory_table.name)), | ||
| None => match &self.create_view { | ||
| Some(create_view) => Ok(format!("{}", create_view.name)), | ||
| None => panic!("Encountered a non CreateMemoryTable/CreateView type in get_name"), |
Collaborator
There was a problem hiding this comment.
We should try replacing the panic with a python error
Collaborator
Author
There was a problem hiding this comment.
Good point - might also be worth it to do a follow up PR applying this change to some of the other plan types, which also panic in similar situations
jdye64
requested changes
Aug 3, 2022
Collaborator
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
Few nits but overall looks good. Thanks!
ayushdg
approved these changes
Aug 4, 2022
Collaborator
ayushdg
left a comment
ayushdg
left a comment
There was a problem hiding this comment.
Thanks for this! Changes lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
CREATE TABLE ASandCREATE VIEW ASstatements. Some follow up stuff to look into:schema_namethrough DataFusion instead of hard-codingCreateTableAsPlugin.convertandContext.sqlin one utility function