Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Add Pangoro Runtime#773

Merged
hackfisher merged 46 commits intomasterfrom
xavier-pangoro
Aug 26, 2021
Merged

Add Pangoro Runtime#773
hackfisher merged 46 commits intomasterfrom
xavier-pangoro

Conversation

@aurexav
Copy link
Copy Markdown
Member

@aurexav aurexav commented Aug 24, 2021

No description provided.

@aurexav aurexav marked this pull request as draft August 24, 2021 07:40
@aurexav aurexav added the N-Pangoro [Network] Pangoro label Aug 24, 2021
@github-actions

This comment has been minimized.

"pangolin-local" | "local" => Box::new(pangolin_chain_spec::local_testnet_config()),
"pangoro" => Box::new(pangoro_chain_spec::config()?),
"pangoro-genesis" => Box::new(pangoro_chain_spec::build_spec_config()),
"pangoro-dev" => Box::new(pangoro_chain_spec::development_config()),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's highly recommended to add pangoro-local, then the local test would be much easier. This is a low-priority issue, we can do it later.

@aurexav aurexav added the Bridge label Aug 26, 2021
@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Aug 26, 2021

I think we should also reset Pangolin.

BridgeMillauGrandpa -> BridgePangoroGrandpa

@xiaoch05
Copy link
Copy Markdown
Contributor

should we upgrade parity-bridge-common now or later? It has some new features we may need.

@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Aug 26, 2021

should we upgrade parity-bridge-common now or later? It has some new features we may need.

Does it affect the genesis? If yes I'll delete the genesis to prevent the repo size grow too large.

Let's do that in another PR.

@boundless-forest
Copy link
Copy Markdown
Member

should we upgrade parity-bridge-common now or later? It has some new features we may need.

Please do it later. This pull request is too large and hard to review.

Copy link
Copy Markdown
Member

@boundless-forest boundless-forest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Aug 26, 2021

@xiaoch05 have you check the changes?

@xiaoch05
Copy link
Copy Markdown
Contributor

@xiaoch05 have you check the changes?

Yes, we need some commits such as
paritytech/parity-bridges-common#982
paritytech/parity-bridges-common#1004
paritytech/parity-bridges-common#935
paritytech/parity-bridges-common#1015

better to upgrade it later in another pr.

@hackfisher hackfisher merged commit 3b9b12d into master Aug 26, 2021
@hackfisher hackfisher deleted the xavier-pangoro branch August 26, 2021 11:32
@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Aug 26, 2021

@xiaoch05 have you check the changes?

Yes, we need some commits such as
paritytech/parity-bridges-common#982
paritytech/parity-bridges-common#1004
paritytech/parity-bridges-common#935
paritytech/parity-bridges-common#1015

better to upgrade it later in another pr.

This will break the genesis.
I've to re-build them.

(And the repo's size will increase)

@aurexav
Copy link
Copy Markdown
Member Author

aurexav commented Sep 2, 2021

This PR bump substrate from darwinia-v0.11.3 to darwinia-v0.11.4 accidentally.

Leave a comment here to mark.

@aurexav aurexav added Crab N-Pangolin [Network] Pangolin C-Substrate [Component] Something about Substrate labels Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

C-Substrate [Component] Something about Substrate N-Pangolin [Network] Pangolin N-Pangoro [Network] Pangoro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants