Conversation
svyatonik
commented
Jun 22, 2021
svyatonik
commented
Jun 22, 2021
tomusdrw
reviewed
Jun 22, 2021
| type RialtoSourceClient = SubstrateMessagesSource< | ||
| Rialto, | ||
| Millau, | ||
| RialtoMessagesToMillau, |
Contributor
There was a problem hiding this comment.
Couldn't the lane contain all other necessary generic types? It seems it's bound with them anyway?
Contributor
Author
There was a problem hiding this comment.
This requires some refactoring - simply using associated types from lane causes cycle detected when using associated type bounds. But ok - I'll try to solve it here.
Contributor
There was a problem hiding this comment.
No worries, let's log this and leave for a potential follow up PR.
Contributor
Author
There was a problem hiding this comment.
I've tried some attempts, but all are adding a lot of changes to this PR, so right - let's keep it for other PRs: #1033
tomusdrw
approved these changes
Jun 25, 2021
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #997