Merged
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
joshqsumner
approved these changes
Jan 28, 2026
Contributor
joshqsumner
left a comment
There was a problem hiding this comment.
Works locally for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
There are some minor differences between numpy 1 and 2 keyword arguments. In #1687 we pinned to numpy >=2, but this prevents us from installing some things that still rely on numpy 1, and we don't need to be that restrictive if we modify the numpy function inputs to be more general, which is done in this PR. This PR also applies the altair v5 pin in the
environment.ymlfile that was missed in #1845Type of update
Is this a: Bug fix
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md