Skip to content

Fix numpy and altair version issues#1870

Merged
nfahlgren merged 2 commits intomainfrom
fix-numpy-version-issues
Jan 28, 2026
Merged

Fix numpy and altair version issues#1870
nfahlgren merged 2 commits intomainfrom
fix-numpy-version-issues

Conversation

@nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jan 28, 2026

Describe your changes
There are some minor differences between numpy 1 and 2 keyword arguments. In #1687 we pinned to numpy >=2, but this prevents us from installing some things that still rely on numpy 1, and we don't need to be that restrictive if we modify the numpy function inputs to be more general, which is done in this PR. This PR also applies the altair v5 pin in the environment.yml file that was missed in #1845

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.10.2 milestone Jan 28, 2026
@nfahlgren nfahlgren added the bugfix Bug fixes label Jan 28, 2026
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Jan 28, 2026
@deepsource-io
Copy link

deepsource-io bot commented Jan 28, 2026

Here's the code health analysis summary for commits 004a6a0..8dcd40f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren requested a review from joshqsumner January 28, 2026 18:02
Copy link
Contributor

@joshqsumner joshqsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally for me

@nfahlgren nfahlgren merged commit 43ce1be into main Jan 28, 2026
5 checks passed
@nfahlgren nfahlgren deleted the fix-numpy-version-issues branch January 28, 2026 19:44
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fixes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants