Skip to content

fix(AdvancedMagnifyTool): Exceptions are no longer thrown for the AdvancedMagnifyTool #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sedghi merged 1 commit into from
Oct 28, 2025
Merged

fix(AdvancedMagnifyTool): Exceptions are no longer thrown for the AdvancedMagnifyTool #2427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tools/src/stateManagement/segmentation/internalAddSegmentationRepresentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ function internalAddSegmentationRepresentation(
if (segmentKeys.length > 0) {
firstSegmentIndex = segmentKeys.map((k) => Number(k)).sort()[0];
}
setActiveSegmentIndex(segmentationId, firstSegmentIndex);
}
setActiveSegmentIndex(segmentationId, firstSegmentIndex);
}

if (representationInput.type === SegmentationRepresentations.Contour) {
Expand Down
4 changes: 2 additions & 2 deletions packages/tools/src/tools/AdvancedMagnifyTool.ts
View file
Open in desktop
Copy link
Copy Markdown
Collaborator Author

@jbocce jbocce Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file fix an exception being thrown for volume viewports that was occurring at least since commit e1b5bc6 (Feb 28, 2025), but likely has existed longer. However even with these changes the magnify glass still does not behave like it does for stack viewports.

See #2428

Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const MAGNIFY_VIEWPORT_INITIAL_RADIUS = 125;
const { Events: csEvents } = Enums;

// TODO: find a better to identify segmentation actors
const isSegmentation = (actor) => actor.uid !== actor.referencedId;
const isSegmentation = (actor) => !!actor.representationUID;

export type AutoPanCallbackData = {
points: {
Expand Down Expand Up @@ -1355,7 +1355,7 @@ class AdvancedMagnifyViewport {
const actors = sourceViewport.getActors();
const volumeInputArray: Types.IVolumeInput[] = actors
.filter((actor) => !isSegmentation(actor))
.map((actor) => ({ volumeId: actor.uid }));
.map((actor) => ({ volumeId: actor.referencedId }));

magnifyViewport.setVolumes(volumeInputArray).then(() => {
this._isViewportReady = true;
Expand Down
Loading