Skip to content

fix(AdvancedMagnifyTool): Exceptions are no longer thrown for the AdvancedMagnifyTool#2427

Merged
sedghi merged 1 commit into
mainfrom
fix/CS-41-advanced-magnifying-tool
Oct 28, 2025
Merged

fix(AdvancedMagnifyTool): Exceptions are no longer thrown for the AdvancedMagnifyTool#2427
sedghi merged 1 commit into
mainfrom
fix/CS-41-advanced-magnifying-tool

Conversation

@jbocce
Copy link
Copy Markdown
Collaborator

@jbocce jbocce commented Oct 27, 2025

Context

#2412

Changes & Results

Upon investigation, it was determined that in part changes in #2322 contributed to #2412. So we only set the active segment index if there is a segmentation representation.

Further investigation showed that the AdvancedMagnifyTool has NOT been working on volume viewports for at least since February of 2025. In general, the click to apply the AdvancedMagnifyTool on a volume viewport would immediately throw an exception. So, in AdvancedMagnifyTool, we now use better detection for segmentation actors. Now the exception is gone, the magnify glass is displayed, but behaviour is still not equivalent to that for a stack viewport. A new issue will be logged soon.

See #2428.

Testing

See #2412

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Windows 11
  • "Node version: 23.9.0
  • "Browser: Chrome 141.0.7390.123

…is a segmentation representation.

In AdvancedMagnifyTool, used better detection for segmentation actors.
@jbocce jbocce requested a review from sedghi October 27, 2025 11:34
Copy link
Copy Markdown
Collaborator Author

@jbocce jbocce Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file fix an exception being thrown for volume viewports that was occurring at least since commit e1b5bc6 (Feb 28, 2025), but likely has existed longer. However even with these changes the magnify glass still does not behave like it does for stack viewports.

See #2428

@sedghi sedghi merged commit a1ed218 into main Oct 28, 2025
10 checks passed
@sedghi sedghi deleted the fix/CS-41-advanced-magnifying-tool branch October 28, 2025 13:10
@maxcomperatore
Copy link
Copy Markdown

beautifully done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants