fix(AdvancedMagnifyTool): Exceptions are no longer thrown for the AdvancedMagnifyTool#2427
Merged
Merged
Conversation
…is a segmentation representation. In AdvancedMagnifyTool, used better detection for segmentation actors.
jbocce
commented
Oct 27, 2025
Collaborator
Author
There was a problem hiding this comment.
sedghi
approved these changes
Oct 27, 2025
|
beautifully done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
#2412
Changes & Results
Upon investigation, it was determined that in part changes in #2322 contributed to #2412. So we only set the active segment index if there is a segmentation representation.
Further investigation showed that the AdvancedMagnifyTool has NOT been working on volume viewports for at least since February of 2025. In general, the click to apply the AdvancedMagnifyTool on a volume viewport would immediately throw an exception. So, in AdvancedMagnifyTool, we now use better detection for segmentation actors. Now the exception is gone, the magnify glass is displayed, but behaviour is still not equivalent to that for a stack viewport. A new issue will be logged soon.
See #2428.
Testing
See #2412
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment