feat(viewer): add support for pure HTML cluster feature - part 4

[danpriori]

Type of change

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-6392

This PR is part of a stacked PR to support the pure HTML cluster feature with an internal counter.

• feat(viewer): add support for pure HTML cluster feature - part 1 #5504
• feat(viewer): add support for pure HTML cluster feature - part 2 #5505
• feat(viewer): add support for pure HTML cluster feature - part 3 #5509
• feat(viewer): add support for pure HTML cluster feature - part 4 #5507
• feat(viewer): add support for pure HTML cluster feature - part 5 #5508

This PR implements the wiring of cluster feature into image360 facade and image360 collection classes.

How has this been tested? 🔍

It was tested by building it locally and testing it on cog-3d in scenes that have a lot of 360s, such as the Hybrid Mapping scene and the Ivar Aasen Demo (CAD, PC, 360).

Test instructions ℹ️

• Open unified 3d in a scene with a large collection of 360s (example: Hybrid Mapping).
• Navigate through the 360s and clusters without entering a 360 image.
• Observe the clusters appearing with the numbering of how many points that cluster represents.
• Click on one of the clusters.
• Observe the camera zooming in so that the cluster expands, showing the points it represents.

screen-capture.44.webm

Checklist ☑️

• I am happy with this implementation.
• I have performed a self-review of my own code.
• I have added unit and visuals tests to prove that my feature works to the best of my ability.
• I have added documentation to new and changed elements; both public and internally shared ones
• I have refactored the code for testability, readability and extendibility to the best of my ability.
• I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

[codecov]

Codecov Report

❌ Patch coverage is 86.84211% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.51%. Comparing base (c988b8a) to head (0cc223b).

Files with missing lines	Patch %	Lines
...es/360-images/src/collection/Image360Collection.ts	0.00%	30 Missing ⚠️

Additional details and impacted files

@@                                         Coverage Diff                                         @@
##           danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part3    #5507      +/-   ##
===================================================================================================
+ Coverage                                                            73.30%   73.51%   +0.21%     
===================================================================================================
  Files                                                                  467      467              
  Lines                                                                47451    47675     +224     
  Branches                                                              3726     3768      +42     
===================================================================================================
+ Hits                                                                 34783    35050     +267     
+ Misses                                                               12534    12491      -43     
  Partials                                                               134      134              

Files with missing lines	Coverage Δ
viewer/packages/360-images/src/Image360Facade.ts	81.84% <100.00%> (+36.79%)	⬆️
...images/src/collection/DefaultImage360Collection.ts	68.36% <100.00%> (+8.67%)	⬆️
...images/src/collection/Image360CollectionFactory.ts	100.00% <100.00%> (ø)
...er/packages/360-images/src/icons/IconCollection.ts	93.12% <100.00%> (+0.01%)	⬆️
...es/360-images/src/collection/Image360Collection.ts	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[danpriori]

/gemini review

[gemini-code-assist]

Code Review

This pull request effectively wires up the HTML cluster feature into the Image360Facade and Image360Collection classes, including adding necessary methods and tests. The changes are well-structured. However, I've identified a potential issue in the implementation of intersectCluster that could lead to an inconsistent UI state. My feedback focuses on resolving this to ensure correct hover behavior across multiple image collections.

[nilscognite]

LGTM