feat(viewer): add support for pure HTML cluster feature - part 1

[danpriori]

Type of change

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-6392

This PR is part of a stacked PR to support the pure HTML cluster feature with an internal counter.

• feat(viewer): add support for pure HTML cluster feature - part 1 #5504
• feat(viewer): add support for pure HTML cluster feature - part 2 #5505
• feat(viewer): add support for pure HTML cluster feature - part 3 #5509
• feat(viewer): add support for pure HTML cluster feature - part 4 #5507
• feat(viewer): add support for pure HTML cluster feature - part 5 #5508

In this PR, I'm adding mainly the new IconOctree method getLODByDistanceWithClustering to get LOD nodes based on camera distance with enhanced clustering for pure cluster visualization.

How has this been tested? 🔍

It was tested by building it locally and testing it on cog-3d in scenes that have a lot of 360s, such as the Hybrid Mapping scene and the Ivar Aasen Demo (CAD, PC, 360).

Test instructions ℹ️

• Open unified 3d in a scene with a large collection of 360s (example: Hybrid Mapping).
• Navigate through the 360s and clusters without entering a 360 image.
• Observe the clusters appearing with the numbering of how many points that cluster represents.
• Click on one of the clusters.
• Observe the camera zooming in so that the cluster expands, showing the points it represents.

screen-capture.44.webm

Checklist ☑️

• I am happy with this implementation.
• I have performed a self-review of my own code.
• I have added unit and visuals tests to prove that my feature works to the best of my ability.
• I have added documentation to new and changed elements; both public and internally shared ones
• I have refactored the code for testability, readability and extendibility to the best of my ability.
• I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

[codecov]

Codecov Report

❌ Patch coverage is 82.89474% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.84%. Comparing base (db985e4) to head (372d74b).
⚠️ Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
viewer/packages/360-images/src/types.ts	0.00%	11 Missing ⚠️
viewer/packages/3d-overlays/src/IconOctree.ts	96.92%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5504      +/-   ##
==========================================
- Coverage   72.84%   72.84%   -0.01%     
==========================================
  Files         463      463              
  Lines       46515    46508       -7     
  Branches     3590     3601      +11     
==========================================
- Hits        33884    33878       -6     
+ Misses      12537    12536       -1     
  Partials       94       94              

Files with missing lines	Coverage Δ
viewer/packages/3d-overlays/src/IconOctree.ts	94.79% <96.92%> (+0.34%)	⬆️
viewer/packages/360-images/src/types.ts	0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[danpriori]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new method getLODByDistanceWithClustering to IconOctree for enhanced clustering, along with a new data type and corresponding tests. The implementation is generally solid. However, I've identified a performance concern in the new getNodeSize helper method, where a new Vector3 object is allocated on each call within a loop. My feedback includes a suggestion to optimize this by reusing a Vector3 instance to prevent potential performance degradation from garbage collection.

[pramod-cog]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new type for cluster intersection data and a new method getLODByDistanceWithClustering in IconOctree for enhanced clustering. The new method incorporates node size and maximum depth for better granularity. Tests for this new functionality have been added. However, there is a critical inconsistency regarding the getLODByDistance method: its calls in IconOctree.test.ts have been updated to remove the clusteringLevel parameter, but the method signature in IconOctree.ts still declares and uses this parameter, which will lead to a runtime error or unexpected behavior.

[nilsfremming]

I had some comments

[nilscognite]

LGTM

[pramod-cog]

risk review ok