feat(viewer): add support for pure HTML cluster feature - part 2#5505
Open
danpriori wants to merge 18 commits intodanpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part1from
Conversation
…on-part1' into danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part2
…on-part2' into danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part3
…on-part1' into danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part2
…on-part3' into danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part2
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part1 #5505 +/- ##
===================================================================================================
+ Coverage 72.87% 73.02% +0.15%
===================================================================================================
Files 463 467 +4
Lines 46607 47026 +419
Branches 3616 3663 +47
===================================================================================================
+ Hits 33963 34343 +380
- Misses 12511 12587 +76
+ Partials 133 96 -37
🚀 New features to boost your workflow:
|
This was referenced Feb 8, 2026
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an HTML-based clustering feature for 360-degree image icons. The implementation includes rendering logic, styling, and necessary type definitions. The changes are well-structured and include unit tests. My review focuses on a critical memory leak issue in the HtmlClusterRenderer's disposal logic, for which I've provided a detailed explanation and a suggested fix to ensure proper resource cleanup.
…on-part1' into danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part2
…on-part1' into danpriori/BND3D-6392-pure-3d-clustering-360s-HTML-version-part2
Contributor
haakonflatval-cognite
left a comment
There was a problem hiding this comment.
Some initial comments - nothing big, looking good so far!
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
…n screenposition, move style container into cluster container and some refactoring
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.test.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.test.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.test.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/icons/clustering/HtmlClusterRenderer.test.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-6392
This PR is part of a stacked PR to support the pure HTML cluster feature with an internal counter.
This PR implements the HTML clustering feature, including rendering and styling.
How has this been tested? 🔍
It was tested by building it locally and testing it on cog-3d in scenes that have a lot of 360s, such as the Hybrid Mapping scene and the Ivar Aasen Demo (CAD, PC, 360).
Test instructions ℹ️
screen-capture.44.webm
Checklist ☑️