Merged
Conversation
Member
|
This change is |
72 tasks
petermattis
approved these changes
Dec 24, 2025
Contributor
petermattis
left a comment
petermattis
left a comment
There was a problem hiding this comment.
Feel free to suggest a better way to detect potential breakage during Go version upgrades.
@petermattis made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.
This was referenced Dec 25, 2025
RaduBerinde
pushed a commit
to cockroachdb/pebble
that referenced
this pull request
Dec 25, 2025
Update github.com/cockroachdb/swiss to include Go 1.26 support from * cockroachdb/swiss#50
RaduBerinde
pushed a commit
to cockroachdb/pebble
that referenced
this pull request
Dec 25, 2025
Update github.com/cockroachdb/swiss to include Go 1.26 support from * cockroachdb/swiss#50
This was referenced Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
Alternatively upper limit should be removed entirely or the the module even deprecated to encourage users to use swiss tables from standard library directly (https://go.dev/blog/swisstable )
Please note, that
GOEXPERIMENT=noswissmapflag was already removed in Go 1.26, seeIncompatibility surfaced downstream in:
CI tests passing in test PR: