Conversation
|
You'll also need to update the version and SHA256 sum in the termux-packages/scripts/build/setup/termux_setup_golang.sh Lines 6 to 7 in f08abf4 |
Done, thanks |
|
Humm, the shas on those 2 files were different, is there some other process to get the sha for the second file? I just used the same one on both... I followed the instructions from the |
|
Yes they are different. You should be able to get the checksum for the second one from the error message it throws for an incorrect checksum. |
This comment has been minimized.
This comment has been minimized.
a2a7b59 to
c468970
Compare
This comment has been minimized.
This comment has been minimized.
|
in the failed tests I see, for example that the sha for |
|
Alright looks like |
Yes that should be done in this PR and can be a separate commit for each package that needs a build fix. |
|
I've updated the checksum for |
|
ok, so, the issue with |
|
@TomJo2000 I got the package to build on my local and pushed the solution for each on a separate commit, I'm not sure if the approach I took is to hacky but it seems to work, at least I was able to reproduce the failures before and not anymore after... Please have a look when you have some time, and let me know what you think. |
TomJo2000
left a comment
There was a problem hiding this comment.
Those packages that are getting rebuilt are gonna need revision bumps.
You can use our semi-automated revbump utility for that.
./scripts/bin/revbump usql nexttrace kubo
You can also automatically mark those changes for squashing using;
git commit --squash=<commitish>, your tab completion should be able to help you out with the hashes.
Those will then get moved into position automatically the next time you do a git rebase -i, given that the --autosquash flag is also passed, or you have set;
[rebase]
autosquash = truein your ~/.config/git/config (or ~/.gitconfig).
|
I've fixed the typo, and bumped the versions and kept a commit per change, is that what you were requesting? |
TomJo2000
left a comment
There was a problem hiding this comment.
Yep looks good to me.
Thank your for your contribution, I'm just gonna wait for the validation CI to finish before merge.
Bump golang to 1.26