Skip to content

support go1.24#43

Merged
RaduBerinde merged 1 commit intocockroachdb:mainfrom
RaduBerinde:support-go1.24
Feb 28, 2025
Merged

support go1.24#43
RaduBerinde merged 1 commit intocockroachdb:mainfrom
RaduBerinde:support-go1.24

Conversation

@RaduBerinde
Copy link
Member

No description provided.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion


.github/workflows/ci.yaml line 54 at r1 (raw file):

        uses: actions/setup-go@v4
        with:
          go-version: "1.23"

Should we bump this and other actions which mention "1.23" to use "1.24"?

@RaduBerinde RaduBerinde marked this pull request as ready for review February 28, 2025 20:35
Copy link
Member Author

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @petermattis)


.github/workflows/ci.yaml line 54 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

Should we bump this and other actions which mention "1.23" to use "1.24"?

Done. TFTR!

Copy link
Member Author

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @petermattis)


.github/workflows/ci.yaml line 54 at r1 (raw file):

Previously, RaduBerinde wrote…

Done. TFTR!

I also added back go 1.21 since that's the one we require in `go.mod

@RaduBerinde RaduBerinde merged commit a321086 into cockroachdb:main Feb 28, 2025
12 of 13 checks passed
@RaduBerinde RaduBerinde deleted the support-go1.24 branch February 28, 2025 21:06
@stefanb stefanb mentioned this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants