[wit-dylib] add [async-lower] prefix to read and write imports
#2371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized that some of my `componentize-py` tests weren't actually testing what
they were supposed to, and that was due to the `{stream|future}.{read|write}`
intrinsics being lowered synchronously 🤦. This fixes that.
Note that we're still lowering the `{stream|future}.cancel-{read|write}`
intrinsics synchronously, same as the Rust `wit-bindgen` does. We might need to
change that (or make it configurable) for toolchains that actually have a good
async cancellation paradigm.
Signed-off-by: Joel Dice <[email protected]>
alexcrichton
approved these changes
Nov 10, 2025
dicej
added a commit
to dicej/componentize-py
that referenced
this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/componentize-py
that referenced
this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/componentize-py
that referenced
this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to bytecodealliance/componentize-py
that referenced
this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <[email protected]>
mxgordon
pushed a commit
to YellowPapayas/wasm-tools
that referenced
this pull request
Nov 11, 2025
…iance#2371) I realized that some of my `componentize-py` tests weren't actually testing what they were supposed to, and that was due to the `{stream|future}.{read|write}` intrinsics being lowered synchronously 🤦. This fixes that. Note that we're still lowering the `{stream|future}.cancel-{read|write}` intrinsics synchronously, same as the Rust `wit-bindgen` does. We might need to change that (or make it configurable) for toolchains that actually have a good async cancellation paradigm. Signed-off-by: Joel Dice <[email protected]>
mxgordon
added a commit
to YellowPapayas/wasm-tools
that referenced
this pull request
Nov 11, 2025
…ecodealliance#2371)" This reverts commit f30e67e.
mxgordon
added a commit
to YellowPapayas/wasm-tools
that referenced
this pull request
Nov 11, 2025
…ecodealliance#2371)" This reverts commit f30e67e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that some of my
componentize-pytests weren't actually testing what they were supposed to, and that was due to the{stream|future}.{read|write}intrinsics being lowered synchronously 🤦. This fixes that.Note that we're still lowering the
{stream|future}.cancel-{read|write}intrinsics synchronously, same as the Rustwit-bindgendoes. We might need to change that (or make it configurable) for toolchains that actually have a good async cancellation paradigm.