Skip to content

[wit-dylib] add [async-lower] prefix to read and write imports #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

[wit-dylib] add [async-lower] prefix to read and write imports #2371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions crates/wit-dylib/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,34 +216,49 @@ impl Adapter {
);
let function = func.name.clone();

let import = |me: &mut Self, name, params, results| {
let import = |me: &mut Self, prefix, name, params, results| {
let ty = me.define_ty(params, results);
let import =
me.import_func(&module, &format!("[{kind}-{name}-{ordinal}]{function}"), ty);
let import = me.import_func(
&module,
&format!("{prefix}[{kind}-{name}-{ordinal}]{function}"),
ty,
);
me.push_elem(import)
};

let new_elem_index = import(self, "new", vec![], vec![ValType::I64]);
let new_elem_index = import(self, "", "new", vec![], vec![ValType::I64]);
let read_elem_index = import(
self,
"[async-lower]",
"read",
vec![ValType::I32; arg_count],
vec![ValType::I32],
);
let write_elem_index = import(
self,
"[async-lower]",
"write",
vec![ValType::I32; arg_count],
vec![ValType::I32],
);
let cancel_read_elem_index =
import(self, "cancel-read", vec![ValType::I32], vec![ValType::I32]);
let cancel_write_elem_index =
import(self, "cancel-write", vec![ValType::I32], vec![ValType::I32]);
let cancel_read_elem_index = import(
self,
"",
"cancel-read",
vec![ValType::I32],
vec![ValType::I32],
);
let cancel_write_elem_index = import(
self,
"",
"cancel-write",
vec![ValType::I32],
vec![ValType::I32],
);
let drop_readable_elem_index =
import(self, "drop-readable", vec![ValType::I32], vec![]);
import(self, "", "drop-readable", vec![ValType::I32], vec![]);
let drop_writable_elem_index =
import(self, "drop-writable", vec![ValType::I32], vec![]);
import(self, "", "drop-writable", vec![ValType::I32], vec![]);

PayloadData {
new_elem_index,
Expand Down