fix stream/future tests to handle actual asynchrony #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
fix-stream-future-asynchrony
branch
from
99b9cfc to
101e230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the
wit-dylibissue thatbytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes.
Also, bump version to 0.19.2