Remove OpenCV-based lighthouse geometry estimator #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the "Estimate Geometry Simple" feature from the lighthouse tab. This feature required manual OpenCV installation, only supported 1-2 base stations, and appeared broken/grayed-out for users by default.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated "Estimate Geometry Simple" feature from the lighthouse base station geometry configuration dialog. The feature relied on manual OpenCV installation, only supported 1-2 base stations, and was non-functional for most users.
- Removes the "Estimate Geometry Simple" button from the UI layout
- Removes the associated OpenCV-based geometry estimator code and event handlers
- Cleans up unused imports and initialization code
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/cfclient/ui/dialogs/lighthouse_bs_geometry_dialog.ui | Removes the "Estimate Geometry Simple" button widget from the horizontal layout |
| src/cfclient/ui/dialogs/lighthouse_bs_geometry_dialog.py | Removes OpenCV estimator import, initialization code, and click handler method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gemenerik
changed the title
ataffanel
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the "Estimate Geometry Simple" feature from the lighthouse tab. This feature required manual OpenCV installation, only supported 1-2 base stations, and appeared broken/grayed-out for users by default.